-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to inject additional objects to load config #2575
Add an option to inject additional objects to load config #2575
Conversation
Welcome @alan-kut! |
Hi @alan-kut. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign tosi3k |
dd137de
to
62f1a6d
Compare
/assign @mborsz |
/lgtm |
/hold |
@@ -207,6 +208,15 @@ steps: | |||
smallJobSize: {{$SMALL_GROUP_SIZE}} | |||
smallJobsPerNamespace: 1 | |||
|
|||
{{if $ADDITIONAL_PHASES_MODULES}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: is this if necessary? Range over nil should be legal operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed what was done in the #2483
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alan-kut, mborsz, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR allows to inject additional objects via CL2_ADDITIONAL_OBJECTS_MODULES to load/config.yaml.