Add initial image commands to smoke test (partial implementation) #21770
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henry3260 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @henry3260. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
This tests do not have any validations, so they will pass even if the command is broken, but they are very simple.
Another issue is that we cannot run these smoke test locally. We have image tests in the functional test suite that we could run there but this is much more work, so adding these trivial tests seems like a good idea if they are really trivial.
.github/workflows/smoke-test.yml
Outdated
| ./out/minikube image load docker.io/library/alpine ${{ env.LOG_ARGS }} | ||
| - name: minikube image build | ||
| run: | | ||
| ./out/minikube image build -t test-image . ${{ env.LOG_ARGS }} |
There was a problem hiding this comment.
image build needs a Containerfile. You can create one in this test.
There was a problem hiding this comment.
Can we just use the Dockerfile located in test/integration/testdata/docker-env?
| run: | | ||
| ./out/minikube image build -t test-image . ${{ env.LOG_ARGS }} | ||
| ./out/minikube image build -t test-image ./out/testdata/docker-env ${{ env.LOG_ARGS }} |
There was a problem hiding this comment.
All the changes here belongs to previous commit, please squash.
.github/workflows/smoke-test.yml
Outdated
| ${{ env.LOG_ARGS }} | ||
| - name: Copy testdata for image build | ||
| run: | | ||
| echo ">>> Copying testdata to ./out" |
There was a problem hiding this comment.
This log does not add any value, and it hides the actual command if the step command is folded. Please remove it.
.github/workflows/smoke-test.yml
Outdated
| cp -r test/integration/testdata ./out | ||
| - name: minikube image load | ||
| run: | | ||
| ./out/minikube image load docker.io/library/alpine ${{ env.LOG_ARGS }} |
There was a problem hiding this comment.
lets use an image in github or anywhere else to avoid rate limit
There was a problem hiding this comment.
you can use the gcr image for pause
There was a problem hiding this comment.
you can use the gcr image for pause
Can I continue using Alpine in the image build?
henry3260
force-pushed
the
smoke_test
branch
3 times, most recently
from
a54fa06 to
f491b1a
Compare
5 participants
This PR addresses part of issue #21154.
Currently, it adds partial support for image-related smoke tests.
The following commands are implemented so far:
These commands can run in GitHub runners and do not require Kubernetes.
Should we include the image push operation in the smoke test, even though we can't truly validate its success?