Skip to content

gce: bump GCE PD CSI Driver #17712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2025
Merged

gce: bump GCE PD CSI Driver #17712

merged 1 commit into from
Nov 24, 2025
+557 −1,058

Conversation

@upodroid
Copy link
Member

@upodroid upodroid commented Oct 27, 2025

GCE PD CSI Driver is out of date and doesn't work correctly with VMs running C4

C4 instances can't use pd-* disks, so I introduced a new storageclass as described by Google at https://docs.cloud.google.com/kubernetes-engine/docs/how-to/persistent-volumes/hyperdisk#hyperdisk-balanced

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 27, 2025
@upodroid upodroid changed the title bump GCE PD CSI Driver gce: bump GCE PD CSI Driver Oct 27, 2025
@upodroid
Copy link
Member Author

upodroid commented Oct 27, 2025

/cc @hakman

@k8s-ci-robot k8s-ci-robot requested a review from hakman October 27, 2025 13:11
@upodroid
Copy link
Member Author

upodroid commented Oct 27, 2025 •
edited
Loading

:( Their image build pipeline is broken
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver

https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/post-gcp-compute-persistent-disk-csi-driver-push-images

kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#2212

Last release in registry.k8s.io is 1.17.9

justinsb
justinsb reviewed Oct 27, 2025
View reviewed changes
...ata/aws_s3_object_ha-gce.example.com-addons-gcp-pd-csi-driver.addons.k8s.io-k8s-1.23_content
app.kubernetes.io/managed-by: kops
k8s-addon: gcp-pd-csi-driver.addons.k8s.io
kubernetes.io/cluster-service: "true"
name: balanced-storage
Copy link
Member

@justinsb justinsb Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know if GKE does the same thing? We don't need to follow GKE, but it would probably be easier for users if they are the same...

Copy link
Member

@justinsb justinsb Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I can take a look if needed)

Copy link
Member Author

@upodroid upodroid Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GKE doesn't add it by default; users need to create it but the one created by default is broken on C4 nodes. If we ran the k8s test-suite all the pvc tests will fail.

@justinsb
Copy link
Member

justinsb commented Oct 27, 2025

:( Their image build pipeline is broken

I'll take a look at this

@upodroid upodroid mentioned this pull request Nov 3, 2025
Merged
@upodroid upodroid force-pushed the bump-gce-pd-csi-driver branch from 8672ea7 to b344fa7 Compare November 4, 2025 10:37
@upodroid
Copy link
Member Author

upodroid commented Nov 4, 2025

/test pull-kops-e2e-k8s-gce-cilium-hyperdisk

@upodroid upodroid force-pushed the bump-gce-pd-csi-driver branch from b344fa7 to dc4d9ee Compare November 4, 2025 21:05
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2025
@upodroid
Copy link
Member Author

upodroid commented Nov 4, 2025

/test pull-kops-e2e-k8s-gce-cilium-hyperdisk

@upodroid upodroid force-pushed the bump-gce-pd-csi-driver branch from dc4d9ee to fe7877e Compare November 5, 2025 09:24
@upodroid
Copy link
Member Author

upodroid commented Nov 5, 2025

/test pull-kops-e2e-k8s-gce-kindnet-hyperdisk

@upodroid
Copy link
Member Author

upodroid commented Nov 5, 2025

This is almost ready to be merged:

@upodroid
Copy link
Member Author

upodroid commented Nov 5, 2025

/priority critical-urgent

The driver currently being used is too old for arm64 GCE jobs, and they are failing to launch

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 5, 2025
@upodroid upodroid force-pushed the bump-gce-pd-csi-driver branch from fe7877e to 36756f5 Compare November 6, 2025 01:59
@upodroid
Copy link
Member Author

upodroid commented Nov 6, 2025

/skip

/test pull-kops-e2e-k8s-gce-kindnet-hyperdisk

hakman
hakman requested changes Nov 24, 2025
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly, some small nits and questions. You will probably need to rebase this to pass the tests.

@upodroid upodroid force-pushed the bump-gce-pd-csi-driver branch 2 times, most recently from bd3656d to 769135d Compare November 24, 2025 10:03
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2025 •
edited
Loading

@upodroid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-gce-cilium-hyperdisk dc4d9ee link true /test pull-kops-e2e-k8s-gce-cilium-hyperdisk
pull-kops-e2e-k8s-gce-kindnet-hyperdisk 36756f5 link true /test pull-kops-e2e-k8s-gce-kindnet-hyperdisk

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Nov 24, 2025

@upodroid could you re-run hack/update-expected.sh?

@upodroid upodroid force-pushed the bump-gce-pd-csi-driver branch from 769135d to cda8c8c Compare November 24, 2025 10:29
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2025
@upodroid
Copy link
Member Author

upodroid commented Nov 24, 2025

Thank you

@hakman
Copy link
Member

hakman commented Nov 24, 2025

Thank you

Sorry for the delay

@k8s-ci-robot k8s-ci-robot merged commit ff6deb0 into kubernetes:master Nov 24, 2025
27 of 28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb justinsb left review comments

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

4 participants

@upodroid @justinsb @k8s-ci-robot @hakman