-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception using ExternalName with empty endpoint list #13154
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neerfri The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @neerfri. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
Due to kubernetes/kubernetes#114814 kubernetes no longer creates endpoints for services of type
ExternalService
. This in turn causes an exception when using an ingress that is backed by such service.Due to #12952 , which I authored, this causes an exception reported in several recent issues that were opened after the new functionality was released.
I'm still puzzled why the e2e tests in https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/servicebackend/service_externalname.go did not catch those problems on effected versions of Kubernetes.
This is also related to:
What this PR does / why we need it:
We need this to stabilize the behavior of Ingress backend by a service with type ExternalName across different kubernetes versions and going forward.
Types of changes
Which issue/s this PR fixes
fixes #13081
How Has This Been Tested?
Adding tests to the Lua part of the code that was effected covering previously untested behavior and the specific exception from issue #13081
Checklist: