Skip to content

Fix bash-based word count validation for steering elections #8602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

Fix bash-based word count validation for steering elections #8602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hack/verify-steering-election.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@
set -o errexit
set -o nounset
set -o pipefail

shopt -s extglob

# exclude bios before 2021 since some of them have more than 300 words
STEERING_ELECTION_BIOS="$(pwd)/events/elections/!(2017|2018|2019|2020)/candidate-*.md"
export KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..

# exclude bios before 2025 since some of them have more than 300 words
STEERING_ELECTION_BIOS="${KUBE_ROOT}/elections/steering/!(2017|2018|2019|2020|2021|2022|2023|2024)/candidate-*.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

But would it be better to glob the year directory too so folks don't need to remember to update each time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the expectation is for the Go version to validate 2025 and later, so please ignore my last comment. ;)


invalid_bios=0
break=$(printf "=%.0s" $(seq 1 68))
Expand Down