Unify handling of CSI migration feature gate #3139
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gnufied The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
| @@ -47,6 +48,9 @@ type COCommonInterface interface { | |||
| IsPVCSIFSSEnabled(ctx context.Context, featureName string) bool | |||
| // EnableFSS helps enable feature state switch in the FSS config map | |||
| EnableFSS(ctx context.Context, featureName string) error | |||
| // Check if CSI migration is enabled. In true multi-VC clusters CSI | |||
| // migration will be disabled by default | |||
| IsCSIMigrationEnabled(ctx context.Context, cfg *config.Config) bool | |||
There was a problem hiding this comment.
CSI migration is already GA. We are not supposed to disable it.
There was a problem hiding this comment.
It can't work in multi-VC clusters though, regardless of feature gate state. That is why syncer logs those stacktraces in logs. So, the right thing to do here IMO is to disable the state when multiple vCenters are present.
|
@gnufied: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @divyenpatel |
|
@divyenpatel this is a blocker issue for us, because any time our support staff or customer takes a look at these logs, syncer logging these errors seems very weird. Can you either review or reject this PR please? |
Fixes #3133