Update grid component with header rows and hardcoded links. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update names of some variables. - Ignore unknown fields when marshalling from JSON (to avoid proto skew errors). - Add minor unit tests and flesh out existing coverage.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
ameukam
reviewed
Jan 4, 2025
Adds additional header rows (date, time, custom column headers), and links from cells (using a lit context; will be expanded in a follow-up). Also adds some other minor tweaks: - Update styling to make row and column headers sticky on the left and top (respectively) and fix a couple other nits. - Add minor unit tests and flesh out existing coverage. - Run `pnpm format` to fix some minor lint issues.
|
/retest |
ameukam
added a commit
to ameukam/test-infra
that referenced
this pull request
Jan 20, 2025
Bump image used for Typescript tests. Failures are seen in kubernetes-sigs/testgrid#29.
|
/retest |
|
/retest (I need to look into the flake for this test) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the grid component with additional header rows and hardcoded default links (to be fixed/customized in a follow-up).
Also includes some additional coverage, format/lint fixes, styling, and other cleanup along the way. (Split roughly into two commits, one for the grid changes and one for the other changes).
Tested locally with
pnpm start:k8s. For example: