Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mutating Pod template on StatefulSets. #3952

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support mutating Pod template on StatefulSets. #3952

wants to merge 1 commit into from

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support mutating Pod template on StatefulSets.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support mutating Pod template on StatefulSets

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from tenzen-y and trasc January 9, 2025 16:13
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 9, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 9, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit e2a4a76
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6780e7dffda13500083a997e

@mbobrovskyi mbobrovskyi mentioned this pull request Jan 9, 2025
Draft
@mbobrovskyi mbobrovskyi force-pushed the fix/allow-mutate-pod-spec branch 2 times, most recently from 63af302 to 1abe124 Compare January 9, 2025 16:29
kannon92
kannon92 reviewed Jan 9, 2025
View reviewed changes
pkg/util/pod/pod.go Outdated Show resolved Hide resolved
@kannon92
Copy link
Contributor

kannon92 commented Jan 9, 2025

/hold

Looks like e2e tests are legit failing. Please unhold once those are fixed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@mbobrovskyi mbobrovskyi force-pushed the fix/allow-mutate-pod-spec branch 3 times, most recently from 71ae4d5 to d12c54e Compare January 10, 2025 09:08
@mbobrovskyi mbobrovskyi force-pushed the fix/allow-mutate-pod-spec branch from d12c54e to e2a4a76 Compare January 10, 2025 09:26
@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo January 10, 2025 11:01
@mbobrovskyi
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
@mimowo
Copy link
Contributor

mimowo commented Jan 13, 2025

/hold
I would prefer to first get merged #3520. As commented there I would prefer to avoid the refactoring to use Pod reconciler. The reasons: performance - to avoid reconciling per pod, but also it feels to give us more control when doing the support for the "active" field.

I'm ok to revisit the decision if we really need a Pod reconciler, but I don't see the need yet.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
@trasc
Copy link
Contributor

trasc commented Jan 14, 2025

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from trasc January 14, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@mimowo mimowo Awaiting requested review from mimowo

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mbobrovskyi @k8s-ci-robot @kannon92 @mimowo @trasc