📖 add e2e test to validate webhook conversion between versions in the tutorials

[wazery]

This PR introduces an e2e test to validate webhook conversion between versions, as part of the multiversion tutorial e2e tests.

Fixes: #4255

[k8s-ci-robot]

Hi @wazery. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

/ok-to-test

Thank you for the contirbution 🥇
But it is not really checking the conversion yet.
See how we do the same in our e2e tests, https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/e2e/v4/plugin_cluster_test.go#L389-L432

We would need to do something very similar to that.

[camilamacedo86]

Great work 🥇

/lgtm
/approved

[camilamacedo86]

/lgtm cancel
/approved cancel

[camilamacedo86]

Coudl you please rebase with master and ensure that you run:

make install
make generate-docs

TO have all updated accordingly?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wazery
Once this PR has been reviewed and has the lgtm label, please ask for approval from camilamacedo86. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wazery]

make generate-docs

yes I ran them, I also just reran them now and I see no difference in files, the branch is also up to date with master

[camilamacedo86]

/override pull-kubebuilder-e2e-k8s-1-34-0

[k8s-ci-robot]

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-34-0

In response to this:

/override pull-kubebuilder-e2e-k8s-1-34-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wazery]

/override pull-kubebuilder-e2e-k8s-1-34-1

[k8s-ci-robot]

@wazery: wazery unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-kubebuilder-e2e-k8s-1-34-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wazery]

@camilamacedo86 I just fixed the failing test, hope the PR is ready now for merge.

[camilamacedo86]

/override pull-kubebuilder-e2e-k8s-1-34-1

/override pull-kubebuilder-e2e-k8s-1-34-0

[k8s-ci-robot]

@camilamacedo86: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• pull-kubebuilder-e2e-k8s-1-34-1

Only the following failed contexts/checkruns were expected:

• EasyCLA
• netlify/kubebuilder/deploy-preview
• pull-kubebuilder-e2e-k8s-1-32-0
• pull-kubebuilder-e2e-k8s-1-33-0
• pull-kubebuilder-e2e-k8s-1-34-0
• pull-kubebuilder-test
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override pull-kubebuilder-e2e-k8s-1-34-1

/override pull-kubebuilder-e2e-k8s-1-34-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

/override pull-kubebuilder-e2e-k8s-1-34-0

[k8s-ci-robot]

@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-34-0

In response to this:

/override pull-kubebuilder-e2e-k8s-1-34-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

We should instead update the places where those values are defined instead
See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/hack/docs/internal/cronjob-tutorial/sample.go#L19-L34

We can replace all this implementation and just update the const.

[wazery]

I just addressed it, many thanks for the pointer.

[k8s-ci-robot]

@wazery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-e2e-k8s-1-34-1	1361e7e	link	true	/test pull-kubebuilder-e2e-k8s-1-34-1
pull-kubebuilder-e2e-k8s-1-34-0	a305b10	link	true	/test pull-kubebuilder-e2e-k8s-1-34-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.