chore: Install toolchain files to location provided in KUBEBUILDER_ASSETS if set

[javanthropus]

Fixes #N/A

Description

This allows the installation of toolchain files to an arbitrary path by setting the KUBEBUILDER_ASSETS environment variable. This was done in order to avoid the use of sudo in order to create and use a system path. Backward compatibility with the original method is preserved.

How was this change tested?

I ran make toolchain both with and without setting the KUBEBUILDER_ASSETS environment variable. Without it set, the default location of /usr/local/kubebuilder/bin was used and I was prompted for my password by sudo. With it set to a path under my home directory, the indicated path was created without needing sudo, and all toolchain content was copied into place.

I then ran make test with KUBEBUILDER_ASSETS set to the path in my home directory and /usr/local/kubebuilder deleted to prove that everything still works.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: javanthropus
Once this PR has been reviewed and has the lgtm label, please assign mwielgus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @javanthropus!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @javanthropus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

[javanthropus]

This is a stupid simple PR. Can we please get someone to take a quick look? It's like 5 minutes of work at most.

[coveralls]

Pull Request Test Coverage Report for Build 12399183286

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 11 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.1%) to 81.196%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/utils/termination/termination.go	2	92.31%
pkg/test/expectations/expectations.go	2	94.81%
pkg/controllers/provisioning/scheduling/preferences.go	7	86.52%

Totals
Change from base Build 12303032942:	-0.1%
Covered Lines:	9016
Relevant Lines:	11104

---

💛 - Coveralls