-
Notifications
You must be signed in to change notification settings - Fork 462
fix(flatcar): use newer butane instead of ct #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mathieu Grzybek <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @mgrzybek! |
|
Hi @mgrzybek. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tormath1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a Flatcar maintainer, this change looks sane to me. Flatcar does support those new versions of Ignition (v3.x) since years now and one day we will drop Ignition v2.x support.
For Cluster API itself + Ignition v3 that's another story: coreos/fedora-coreos-tracker#2010 (comment)
AndiDog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Co-authored-by: Andreas Sommer <[email protected]>
|
rockylinux-9 failed, let's try again. /retest |
|
@mgrzybek: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Change description
The current Flatcar Linux building procedure uses
ctto create ignition files. However this tool does not support newer versions of ignition files.This PR replaces
ctwithbutane. As a consequence, current "variants" (1.1.0) and "versions" (flatcar) are supported.Related issues
N.A.
Additional context
N.A.