-
Notifications
You must be signed in to change notification settings - Fork 464
Expose network tags for GCE builder #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @anmazzotti! |
|
Hi @anmazzotti. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Signed-off-by: Andrea Mazzotti <[email protected]>
20a1df6 to
baca417
Compare
|
This is blocked on #1888. |
|
/retest |
mboersma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for adding this! Sorry it took us a while to work out our CI issues.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change description
This PR exposes network tags for the GCE builder. See reference for
tagsusage.This can be consumed from user set variables, with a comma separated list, see reference.
For example:
{ "tags": "packer,foo,bar" }This is a small quality of life change to facilitate network management.
Related issues
Additional context