Skip to content

Conversation

@bexxmodd
Copy link
Contributor

/kind test

What this PR does / why we need it:
This adds a CRD validation CI workflow

Which issue(s) this PR fixes:

Fixes #1842

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

@bexxmodd: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

/kind test

What this PR does / why we need it:
This adds a CRD validation CI workflow

Which issue(s) this PR fixes:

Fixes #1842

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g November 19, 2025 05:01
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 19, 2025
@netlify
Copy link

netlify bot commented Nov 19, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 5e0bdab
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/691d5a667f76d50008b4e3e4
😎 Deploy Preview https://deploy-preview-1879--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bexxmodd
Copy link
Contributor Author

/cc @danehans

@kfswain
Copy link
Collaborator

kfswain commented Nov 19, 2025

@bexxmodd
Copy link
Contributor Author

Thanks Beka!!

Is this different from: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/53080981077a431822c383616789a05c4bcc0ce5/Makefile#L179C9-L179C20 ?

Yeah, looking at the shell script it invokes, it looks like it does CRD validation against the defined schema, while crdify analyzes changes to the CRD.

@kfswain
Copy link
Collaborator

kfswain commented Nov 21, 2025

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bexxmodd, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9dccb4b into kubernetes-sigs:main Nov 21, 2025
11 checks passed
@bexxmodd bexxmodd deleted the ci/crdfy branch November 21, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Add Tooling to Check for Incompatible CRD Changes

3 participants