-
Notifications
You must be signed in to change notification settings - Fork 195
Added crd validation ci workflow. #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bexxmodd: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/cc @danehans |
|
Thanks Beka!! Is this different from: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/53080981077a431822c383616789a05c4bcc0ce5/Makefile#L179C9-L179C20 |
Yeah, looking at the shell script it invokes, it looks like it does CRD validation against the defined schema, while |
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bexxmodd, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind test
What this PR does / why we need it:
This adds a CRD validation CI workflow
Which issue(s) this PR fixes:
Fixes #1842
Does this PR introduce a user-facing change?: