-
Notifications
You must be signed in to change notification settings - Fork 175
enhance the log init process #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Frapschen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Frapschen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Heya @Frapschen Could I get a hand in understanding the value add? This PR doesn't seem to change the verbosity specified in our entire logging system, so I don't see how the strings enforce hierarchy of verbosity. Specifically, I appreciate verbosity being distinct from semantic meaning. See point 2 here: https://github.com/go-logr/logr?tab=readme-ov-file#differences-from-daves-ideas |
@kfswain Thank you for explaining about verbosity-levels and semantics, I can follow this design and revert to using numbers. How about other changes, any suggestions? |
8d4ffa7
to
a481157
Compare
Sorry, I just found that:
They are also included in the flagset. I'm a bit confused why we're using two flags to control log verbosity. If the reviewer approves, I'd like to switch to one of the following approaches:
I prefer option 1 over option 2. WDYT @kfswain |
a481157
to
9fb3a03
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR addresses the following changes:
Additional thoughts on point 4: With tracing currently under proposal, we will also need a package to manage the trace SDK. I recommend placing it in /internal/telemetry/trace.
Any other suggestions for improvement are welcome! 😊
Does this PR introduce a user-facing change?: