test: add openai api content array test case #1410
Conversation
|
@zhengkezhou1: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @zhengkezhou1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, zhengkezhou1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: zhengkezhou1 <[email protected]>
Co-authored-by: Nir Rozenbaum <[email protected]>
Co-authored-by: Nir Rozenbaum <[email protected]>
Signed-off-by: zhengkezhou1 <[email protected]>
Signed-off-by: zhengkezhou1 <[email protected]>
zhengkezhou1
force-pushed
the
e2e-openAI-content-array-case
branch
from
771a74d to
c7da095
Compare
k8s-ci-robot
added
size/M
| type Message struct { | ||
| Role string | ||
| Content string // TODO: support multi-modal content | ||
| Content any // Support both string and array content (OpenAI content blocks) |
There was a problem hiding this comment.
here is the problem, i think we can do the same thing just like llm-d-sim https://github.com/llm-d/llm-d-inference-sim/blob/main/pkg/openai-server-api/response.go#L84-L91
There was a problem hiding this comment.
@nirrozenbaum @danehans i think we need to support this first.
| type ContentBlock struct { | ||
| Type string `json:"type"` | ||
| Text string `json:"text,omitempty"` | ||
| ImageURL *ImageBlock `json:"image_url,omitempty"` | ||
| } | ||
|
|
||
| type ImageBlock struct { | ||
| Url string `json:"url"` | ||
| } |
There was a problem hiding this comment.
only for test here, it shouldn't be here.
|
@zhengkezhou1: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind test
What this PR does / why we need it:
adds an end-to-end test case for the OpenAI API content array.
Which issue(s) this PR fixes:
Fixes #925
Does this PR introduce a user-facing change?: