Skip to content

Adding conformance report for Kubvernor #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2025
Merged

Adding conformance report for Kubvernor #1316

merged 5 commits into from
Aug 28, 2025

Conversation

dawid-nowak
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Aug 6, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 85c97f6
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68aef12596729900084cd371
😎 Deploy Preview https://deploy-preview-1316--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dawid-nowak. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2025
@dawid-nowak
Copy link
Contributor Author

ping @ahg-g @nirrozenbaum

robscott
robscott approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dawid-nowak!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2025
@dawid-nowak dawid-nowak requested a review from robscott August 25, 2025 14:47
@dawid-nowak
Copy link
Contributor Author

ping @robscott @nirrozenbaum @ahg-g

nirrozenbaum
nirrozenbaum reviewed Aug 25, 2025
View reviewed changes
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 27, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 27, 2025
@dawid-nowak
Copy link
Contributor Author

pretty please, could we move it forward...
@nirrozenbaum @robscott @ahg-g

@robscott
Copy link
Member

Sorry I missed this!

/lgtm

For approval:

/assign @nirrozenbaum @ahg-g

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@nirrozenbaum
Copy link
Contributor

/approve

@dawid-nowak thanks for your patience with getting this in! 🙏

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dawid-nowak, nirrozenbaum, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7e64f86 into kubernetes-sigs:main Aug 28, 2025
10 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Sep 1, 2025
@dawid-nowak @nirrozenbaum @kfswain
Adding conformance report for Kubvernor (kubernetes-sigs#1316)
8554566 
* Adding conformance report for Kubvernor

* Updating and addressing PR feedback

Signed-off-by: Dawid Nowak <[email protected]>

* Update conformance/reports/v0.5.1/gateway/kubvernor/README.md

Co-authored-by: Nir Rozenbaum <[email protected]>

* Fixing version mismatch

---------

Signed-off-by: Dawid Nowak <[email protected]>
Co-authored-by: Nir Rozenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@robscott robscott Awaiting requested review from robscott

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

Assignees

@robscott robscott

@nirrozenbaum nirrozenbaum

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dawid-nowak @k8s-ci-robot @robscott @nirrozenbaum @ahg-g