Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos in tutorials #4969

Merged
merged 2 commits into from
Dec 23, 2024
Merged

docs: fix typos in tutorials #4969

merged 2 commits into from
Dec 23, 2024

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Dec 22, 2024 •
edited
Loading

Description

  1. Documentation references ServiceIP as a field inside of spec, but this field does not exist and it's actually meant to reference to ClusterIP
  2. Fixes indentation issue in cloudflare tutorial

Fixes #4868
Supersedes #4869
Supersedes #4803

Checklist

  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2024
@k8s-ci-robot k8s-ci-robot requested a review from szuecs December 22, 2024 17:10
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 22, 2024
@mloiseleur mloiseleur mentioned this pull request Dec 22, 2024
Closed
1 task
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 22, 2024
@mloiseleur mloiseleur changed the title docs: fix reference to wrong field in service docs: fix typos in tutorials Dec 22, 2024
@mloiseleur mloiseleur mentioned this pull request Dec 22, 2024
Closed
2 tasks
@mloiseleur
Copy link
Contributor Author

/assign @Raffo

@mloiseleur
Copy link
Contributor Author

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2024
Raffo
Raffo approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5f0147f into kubernetes-sigs:master Dec 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raffo Raffo Raffo approved these changes

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation references the services spec.ServiceIP - this field does not exist!
3 participants
@mloiseleur @k8s-ci-robot @Raffo