-
Notifications
You must be signed in to change notification settings - Fork 1.2k
⚠️ Add native SSA support #3253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+829
−75
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
57712de
:sparkles: Add native SSA support
alvaroaleman ddd44df
Field validation
alvaroaleman ef347e6
Revert "Field validation"
alvaroaleman f58b87a
Explain why we don't update the namespaced client
alvaroaleman 91cc1f5
Client: Force ownership supports Apply
alvaroaleman 912706f
Fieldvalidation wrapper: Do nothing for `Apply`
alvaroaleman b6d3b23
Improve explanation as to why unstructured shouldn't originate from a…
alvaroaleman cc90df3
Test Apply in interceptor
alvaroaleman 7f46e72
Smaller fixes
alvaroaleman a1ba84e
Implement Apply support in the namespaced client
alvaroaleman 3465059
Apply comes first
alvaroaleman ea24e68
Add tests for apply options
alvaroaleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
/* | ||
Copyright 2025 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package client | ||
|
||
import ( | ||
"fmt" | ||
|
||
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
"k8s.io/apimachinery/pkg/runtime/schema" | ||
"k8s.io/utils/ptr" | ||
) | ||
|
||
type unstructuredApplyConfiguration struct { | ||
*unstructured.Unstructured | ||
} | ||
|
||
func (u *unstructuredApplyConfiguration) IsApplyConfiguration() {} | ||
|
||
// ApplyConfigurationFromUnstructured creates a runtime.ApplyConfiguration from an *unstructured.Unstructured object. | ||
// | ||
// Do not use Unstructured objects here that were generated from API objects, as its impossible to tell | ||
// if a zero value was explicitly set. | ||
func ApplyConfigurationFromUnstructured(u *unstructured.Unstructured) runtime.ApplyConfiguration { | ||
return &unstructuredApplyConfiguration{Unstructured: u} | ||
} | ||
|
||
type applyconfigurationRuntimeObject struct { | ||
runtime.ApplyConfiguration | ||
} | ||
|
||
func (a *applyconfigurationRuntimeObject) GetObjectKind() schema.ObjectKind { | ||
return a | ||
} | ||
|
||
func (a *applyconfigurationRuntimeObject) GroupVersionKind() schema.GroupVersionKind { | ||
return schema.GroupVersionKind{} | ||
sbueringer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
func (a *applyconfigurationRuntimeObject) SetGroupVersionKind(gvk schema.GroupVersionKind) {} | ||
|
||
func (a *applyconfigurationRuntimeObject) DeepCopyObject() runtime.Object { | ||
panic("applyconfigurationRuntimeObject does not support DeepCopyObject") | ||
} | ||
|
||
func runtimeObjectFromApplyConfiguration(ac runtime.ApplyConfiguration) runtime.Object { | ||
return &applyconfigurationRuntimeObject{ApplyConfiguration: ac} | ||
} | ||
|
||
func gvkFromApplyConfiguration(ac applyConfiguration) (schema.GroupVersionKind, error) { | ||
var gvk schema.GroupVersionKind | ||
gv, err := schema.ParseGroupVersion(ptr.Deref(ac.GetAPIVersion(), "")) | ||
if err != nil { | ||
return gvk, fmt.Errorf("failed to parse %q as GroupVersion: %w", ptr.Deref(ac.GetAPIVersion(), ""), err) | ||
} | ||
gvk.Group = gv.Group | ||
gvk.Version = gv.Version | ||
gvk.Kind = ptr.Deref(ac.GetKind(), "") | ||
|
||
return gvk, nil | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.