🐛 KCP: Grant delete permissions to Secrets.

[Gacko]

What this PR does / why we need it:

In clusters with the OwnerReferencesPermissionEnforcement admission controller enabled, the KubeadmControlPlane Controller Manager fails to update the owner references of Secrets:

E1128 06:20:28.361646       1 controller.go:353] "Reconciler error" err="error in ensuring cluster certificates ownership: failed to set ownerReference: failed to patch Secret <namespace>/<cluster>-ca: secrets \"<cluster>-ca\" is forbidden: cannot set an ownerRef on a resource you can't delete: , <nil>" controller="kubeadmcontrolplane" controllerGroup="controlplane.cluster.x-k8s.io" controllerKind="KubeadmControlPlane" KubeadmControlPlane="<namespace>/<cluster>" namespace="<namespace>" name="<cluster>" reconcileID="8ebb9dfb-a5f7-40ae-ae13-a3b77fd1af5c"

/area provider/control-plane-kubeadm

[k8s-ci-robot]

@Gacko: The label(s) area/area/provider/control-plane-kubeadm cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

In clusters with the OwnerReferencesPermissionEnforcement admission controller enabled, the KubeadmControlPlane Controller Manager fails to update the owner references of Secrets:

E1128 06:20:28.361646       1 controller.go:353] "Reconciler error" err="error in ensuring cluster certificates ownership: failed to set ownerReference: failed to patch Secret <namespace>/<cluster>-ca: secrets \"<cluster>-ca\" is forbidden: cannot set an ownerRef on a resource you can't delete: , <nil>" controller="kubeadmcontrolplane" controllerGroup="controlplane.cluster.x-k8s.io" controllerKind="KubeadmControlPlane" KubeadmControlPlane="<namespace>/<cluster>" namespace="<namespace>" name="<cluster>" reconcileID="8ebb9dfb-a5f7-40ae-ae13-a3b77fd1af5c"

/area area/provider/control-plane-kubeadm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[AndiDog]

Shouldn't this only be on finalizers (as done this CAPA PR example)?

[AndiDog]

ensureCertificatesOwnerRef indeed sets the owner reference and therefore seems to need delete permission as of https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#ownerreferencespermissionenforcement – @Gacko and me clarified this in chat. Excerpt from the docs:

This admission controller protects the access to the metadata.ownerReferences of an object so that only users with delete permission to the object can change it. This admission controller also protects the access to metadata.ownerReferences[x].blockOwnerDeletion of an object, so that only users with update permission to the finalizers subresource of the referenced owner can change it.

Leaving this comment here for others reviewers as reference.

[AndiDog]

LGTM

[Gacko]

/retest

[fabriziopandini]

@Gacko thanks for this PR!
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 77e4048773bb0f8628cf6c35469942edc5ae77e4

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

/cherry-pick release-1.12

[k8s-infra-cherrypick-robot]

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@fabriziopandini: new pull request created: #13097

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.