🌱 Update release notes tool to handle multiples_areas and colons #12738
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chandankumar4 <[email protected]>
k8s-ci-robot
added
area/release
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
chandankumar4
changed the title
sbueringer
reviewed
Sep 8, 2025
| return entry | ||
| } | ||
|
|
||
| // UpdateTitle updates a title by removing the "MULTIPLE_AREAS[]" substrings and multiple colons(:). |
There was a problem hiding this comment.
Q: When does the "multiple colon" case happen?
sbueringer
reviewed
Sep 8, 2025
| // UpdateTitle updates a title by removing the "MULTIPLE_AREAS[]" substrings and multiple colons(:). | ||
| func updateTitle(input string) string { | ||
| // Remove "MULTIPLE_AREAS[" from the input | ||
| input = strings.Replace(input, "MULTIPLE_AREAS[", "", 1) |
There was a problem hiding this comment.
What about simply not adding MULTIPLE_AREAS wherever we do that, so that we don't have to remove it here again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
MULTIPLE_AREASin the generated notesMULTIPLE_AREAS[KCP/CABPK]: Change envVars fields from []EnvVar to *[]EnvVar (#12539)toKCP/CABPK: Change envVars fields from []EnvVar to *[]EnvVar (#12539)Testing:Framework: Watch logs from init containers (#12208)toTesting/Framework: Watch logs from init containers (#12208)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes: #12280
/area release