✨ Implement Priority and Serial settings for discovered handlers#11818
✨ Implement Priority and Serial settings for discovered handlers#11818Danil-Grigorev wants to merge 1 commit intokubernetes-sigs:mainfrom
Priority and Serial settings for discovered handlers#11818Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Priority and Serial settings for discovered handlersPriority and Serial settings for discovered handlers
a77347a to
42b3f4e
Compare
Priority and Serial settings for discovered handlersPriority and Serial settings for discovered handlers
9fb72a6 to
7d2e096
Compare
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
7d2e096 to
f034ec7
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
In-place upgrades defines
machine-updatesprocess as looping until completion for each registered updater.In order to leverage runtime extensions in processing these updaters, handler execution needs to be able to block (retry until completion) on individual updater, in case it responds with pending status before requesting other unfinished hooks. This PR introduces
serialsetting for the handler discovery.Additionally, current handlers list is not guarantied to be ordered, so it may cause a situation when:
On the second iteration:
To address this, a
priorityfield is added, which allows updaters to declare execution order.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes rancher/highlander#118
/area runtime-sdk