🌱 Add unit tests for failure domain in KCP

[arshadd-b]

(🌱 )

What this PR does / why we need it:
This improves the coverage for failure domain in KCP

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #11602

[k8s-ci-robot]

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[arshadd-b]

Hi @fabriziopandini
I have noticed that in control_plane.go file there are no test cases for these functions
https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/internal/control_plane.go#L325
https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/internal/control_plane.go#L355
This PR doesn't cover these , Is it expected to cover these as well ?
I can raise a different PR covering these functions
Thanks

[chrischdi]

/ok-to-test

[nrb]

/area testing

[nrb]

Thanks for adding tests! Left a few suggestions.

[arshadd-b]

Hi @nrb I have addressed all the review comments, could you please a look
Thanks

[nrb]

/lgtm
/label tide/merge-method-squash

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ff32b349a0dcf2bf4a56211bd5f41847f95a71c4

[sbueringer]

/assign @fabriziopandini

[chrischdi]

/title 🌱 Add unit tests for failure domain in KCP

[chrischdi]

/retitle 🌱 Add unit tests for failure domain in KCP

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from fabriziopandini. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nrb]

Looks like a couple of the new test cases are failing in CI

[nrb]

This test is failing CI.

{Failed  === RUN   TestControlPlane/Next_Failure_Domains
    control_plane_test.go:181: 
        Unexpected error:
            <*errors.withStack | 0xc0009beae0>: 
            failed to retrieve infra obj for machine "m1": failed to retrieve GenericInfrastructureMachine m1: no matches for kind "GenericInfrastructureMachine" in version "infrastructure.cluster.x-k8s.io/v1beta1"
            {
                error: <*errors.withMessage | 0xc00131c4e0>{
                    cause: <*errors.withStack | 0xc0009beab0>{
                        error: <*errors.withMessage | 0xc00131c4c0>{
                            cause: <*meta.NoKindMatchError | 0xc00097ad00>{
                                GroupKind: {
                                    Group: "infrastructure.cluster.x-k8s.io",
                                    Kind: "GenericInfrastructureMachine",
                                },
                                SearchedVersions: ["v1beta1"],
                            },
                            msg: "failed to retrieve GenericInfrastructureMachine m1",
                        },
                        stack: [0x27453eb, 0x32d3805, 0x32d09bf, 0x338eeed, 0x61b5c7, 0x4b9621],
                    },
                    msg: "failed to retrieve infra obj for machine \"m1\"",
                },
                stack: [0x32d394d, 0x32d09bf, 0x338eeed, 0x61b5c7, 0x4b9621],
            }
        occurred
--- FAIL: TestControlPlane/Next_Failure_Domains (0.01s)
}

[nrb]

This case is failing in CI:

{Failed  === RUN   TestControlPlane/When_infra_and_bootstrap_config_exists
    control_plane_test.go:276: 
        Expected success, but got an error:
            <*meta.NoKindMatchError | 0xc001c9b140>: 
            no matches for kind "GenericInfrastructureMachine" in version "infrastructure.cluster.x-k8s.io/v1beta1"
            {
                GroupKind: {
                    Group: "infrastructure.cluster.x-k8s.io",
                    Kind: "GenericInfrastructureMachine",
                },
                SearchedVersions: ["v1beta1"],
            }
--- FAIL: TestControlPlane/When_infra_and_bootstrap_config_exists (0.01s)
}

[arshadd-b]

will check, Thank you @nrb