Skip to content

🌱Bump go to 1.24.11 #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 8, 2025
Merged

🌱Bump go to 1.24.11 #2881

k8s-ci-robot merged 1 commit into from
Dec 8, 2025
+3 −3

Conversation

@smoshiur1237
Copy link
Contributor

@smoshiur1237 smoshiur1237 commented Dec 4, 2025 •
edited
Loading

Uplift go to 1.24.11

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2025
@netlify
Copy link

netlify bot commented Dec 4, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 4fca5f0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6936c2d902295b000879e9cb
😎 Deploy Preview https://deploy-preview-2881--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@smoshiur1237 smoshiur1237 changed the title 🌱 Bump g01.24.11 🌱 Bump go version to 1.24.11 Dec 4, 2025
lentzi90
lentzi90 reviewed Dec 4, 2025
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
@smoshiur1237
Copy link
Contributor Author

smoshiur1237 commented Dec 4, 2025

/restest

@smoshiur1237 smoshiur1237 changed the title 🌱 Bump go version to 1.24.11 🌱 Ignore irrelevant CVE Dec 4, 2025
@lentzi90
Copy link
Contributor

lentzi90 commented Dec 5, 2025

/approve cancel
Please don't change PRs so much. It is better to open a new when completely changing what a PR does.

Where do you see that govulncheck says we are not affected? In the description I don't see it. In previous cases we saw this:

Your code is affected by 0 vulnerabilities.
This scan also found 1 vulnerability in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.

We may still have to ignore these if they require a newer go version, but we should not claim we are unaffected unless that is true.

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
tuminoid
tuminoid reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You ARE affected by the stdlib issues, if you use certificates, like govulncheck says.

@smoshiur1237
Copy link
Contributor Author

smoshiur1237 commented Dec 5, 2025

/retest

@smoshiur1237
Copy link
Contributor Author

smoshiur1237 commented Dec 8, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2025
@smoshiur1237
Bump go to 1.24.11
4fca5f0 
Signed-off-by: smoshiur1237 <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2025
@smoshiur1237 smoshiur1237 changed the title 🌱 Ignore irrelevant CVE 🌱Bump go to 1.24.11 Dec 8, 2025
@smoshiur1237
Copy link
Contributor Author

smoshiur1237 commented Dec 8, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2025
@smoshiur1237
Copy link
Contributor Author

smoshiur1237 commented Dec 8, 2025

Now it is working
/cc @bnallapeta @lentzi90

@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 December 8, 2025 12:37
lentzi90
lentzi90 reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
tuminoid
tuminoid reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4bbdff3 into kubernetes-sigs:release-0.12 Dec 8, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@bnallapeta bnallapeta Awaiting requested review from bnallapeta

+1 more reviewer

@tuminoid tuminoid tuminoid left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tuminoid tuminoid

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPO Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smoshiur1237 @lentzi90 @k8s-ci-robot @tuminoid