Skip to content

Conversation

bnallapeta
Copy link
Contributor

What this PR does / why we need it:
Introduces OpenStackClusterIdentity CRD to centralize OpenStack credentials across namespaces with access controls.

Key Features:

  • Cluster-scoped credential storage (reduces duplication)
  • Namespace-based access control via namespaceSelector
  • Backward compatible with existing Secret references

Usage:

# Create cluster identity
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha1
kind: OpenStackClusterIdentity
metadata:
  name: production-openstack
spec:
  secretRef:
    name: openstack-credentials
    namespace: capo-system

# Reference from cluster
spec:
  identityRef:
    type: ClusterIdentity
    name: production-openstack
    cloudName: openstack

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2386

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests
    • adds envtest tests
    • adds e2e tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2025
Copy link

netlify bot commented Sep 3, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 174e2e8
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68dcaea9520de70008badaf1
😎 Deploy Preview https://deploy-preview-2682--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 3, 2025
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @bnallapeta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2025
@bnallapeta
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2025
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am almost through reviewing this. A few left that I will try to get done tomorrow. Here are the comments so far

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am quite happy with this now. Still a few nits below.
Could you also squash the commits? Then I think this is good to go 🙂

Signed-off-by: Bharath Nallapeta <[email protected]>
@bnallapeta
Copy link
Contributor Author

bnallapeta commented Oct 1, 2025

Could you also squash the commits?

@lentzi90 I have logically grouped the commits since its a relatively big PR. Will be easier to manage in the future too.
1 for core implementation
1 for unit tests
1 for envtests
1 for e2e

Hope this structure works. Please let me know.

Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes, it is ok to keep the 4 commits I think, the fifth "duplicate" e2e commit was unnecessary but these are good.
/approve

@smoshiur1237 could you also please review this? You should have org membership soon and this is a good way to get more familiar with the code.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2025
@lentzi90
Copy link
Contributor

lentzi90 commented Oct 1, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

[Feature Request] Introduce OpenStackClusterIdentity Resource for Centralized Credential Management
3 participants