-
Notifications
You must be signed in to change notification settings - Fork 92
Add validation for encryptionKeyCRN for VPC Machine spec #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for encryptionKeyCRN for VPC Machine spec #2551
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @ChandrikaHarish. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a3c1ee4 to
9011267
Compare
|
/ok-to-test |
|
can you PTAL? |
anshuman-agarwala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is also applicable for AdditionalVolumes Can you please add it there as well.
Also added some minor comments.
9011267 to
0e8ce14
Compare
Amulyam24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, LGTM!
Thanks @ChandrikaHarish !
0e8ce14 to
ff70faa
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChandrikaHarish, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |

What this PR does / why we need it: IBM Cloud CRN validation regex added at the time of boot volume validation for the encryptionKeyCRN for VPC Machine spec . CRN regex added as referred from doc - https://cloud.ibm.com/apidocs/vpc/latest#get-volume
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: