Skip to content

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Nov 11, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 11, 2025
@netlify
Copy link

netlify bot commented Nov 11, 2025

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 6b098c7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/69162d8d28f65d00089cc8a8
😎 Deploy Preview https://deploy-preview-1556--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cpanato and dims November 11, 2025 15:56
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2025
@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-gcp-build
/test pull-cluster-api-provider-gcp-e2e-test
/test pull-cluster-api-provider-gcp-make
/test pull-cluster-api-provider-gcp-test
/test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-gcp-apidiff
/test pull-cluster-api-provider-gcp-capi-e2e
/test pull-cluster-api-provider-gcp-conformance
/test pull-cluster-api-provider-gcp-conformance-ci-artifacts
/test pull-cluster-api-provider-gcp-coverage
/test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-gcp-apidiff
pull-cluster-api-provider-gcp-build
pull-cluster-api-provider-gcp-e2e-test
pull-cluster-api-provider-gcp-make
pull-cluster-api-provider-gcp-test
pull-cluster-api-provider-gcp-verify

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts
/test pull-cluster-api-provider-gcp-e2e-workload-upgrade

1 similar comment
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-gcp-conformance-ci-artifacts
/test pull-cluster-api-provider-gcp-e2e-workload-upgrade

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2025
@cpanato
Copy link
Member

cpanato commented Nov 12, 2025

@chrischdi those two tests are currently broken, we need to find time to fix it

@chrischdi
Copy link
Member Author

@chrischdi those two tests are currently broken, we need to find time to fix it

That is my plan on this PR :-)

@cpanato
Copy link
Member

cpanato commented Nov 12, 2025

thanks!

@chrischdi chrischdi changed the title [WIP] 🌱 test ci [WIP] 🌱 e2e: fix test for workload-upgrade Nov 12, 2025
@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-gcp-e2e-workload-upgrade

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 12, 2025
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-conformance-ci-artifacts a4a5591 link false /test pull-cluster-api-provider-gcp-conformance-ci-artifacts
pull-cluster-api-provider-gcp-e2e-workload-upgrade f2a4d48 link false /test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member Author

I it is impossible to debug this further with the current CI.

I'd next look at cloud-init / kubelet logs etc for e.g. this machine: k8s-upgrade-and-conformance-fj0afj-control-plane-nxqt8

@chrischdi
Copy link
Member Author

chrischdi commented Nov 13, 2025

Note: maybe shell out to gcloud compute ssh would be a handy way, or use the sdk to do the same via go code.

Prior art of commands which help to get output:

		captureLogs("kubelet.log",
			"sudo journalctl", "--no-pager", "--output=short-precise", "-u", "kubelet.service"),
		captureLogs("containerd.log",
			"sudo journalctl", "--no-pager", "--output=short-precise", "-u", "containerd.service"),
		captureLogs("cloud-init.log",
			"sudo", "cat", "/var/log/cloud-init.log"),
		captureLogs("cloud-init-output.log",
			"sudo", "cat", "/var/log/cloud-init-output.log"),
		captureLogs("kubeadm-service.log",
			"sudo", "cat", "/var/log/kubeadm-service.log"),
		captureLogs("pod-logs.tar.gz",
			"sudo", "tar", "-czf", "-", "-C", "/var/log", "pods"),

https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/test/framework/log/collector.go#L90-L101

@damdo
Copy link
Member

damdo commented Nov 13, 2025

Note: maybe shell out to gcloud compute ssh would be a handy way, or use the sdk to do the same via go code.

I think this would be handy to debug things like this for sure!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2025
@chrischdi
Copy link
Member Author

(Note: didn't work ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants