-
Notifications
You must be signed in to change notification settings - Fork 638
🌱 Enable nobools linter #5752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 Enable nobools linter #5752
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @moko-poi. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
05a09ec to
b926621
Compare
|
/ok-to-test |
|
@moko-poi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
/kind support
What this PR does / why we need it:
Enables the
noboolslinter ingolangci-kaland adds targeted//nolint:kubeapilinterexemptions for existing boolean API fields and test struct fields.This keeps the API surface and behavior fully backward compatible while allowing the stricter linter to be enforced for newly added fields going forward.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5489
Special notes for your reviewer:
//nolint:kubeapilinter // nobools: Existing API field, not changing to preserve backwards compatibility.comments on existing fields.noboolsare either://nolint, orChecklist:
Release note: