Skip to content

✨ Allocate dedicated host when a dedicated host doesn't exist #5631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Allocate dedicated host when a dedicated host doesn't exist #5631

wants to merge 1 commit into from
+1,473 −40

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Aug 26, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Builds on #5548 to enable CAPA to allocate a dedicated host. This removes the requirement that a dedicated host exist prior to instance provisioning. A core assumption of this PR is that there is a 1:1 mapping between an instance and the dedicated host on which it runs. Nothing in this implementation precludes scheduling multiple instances to a given dedicated host, but that is not the goal of this initial implementation.

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes emoji in title
  • adds unit tests

Release note:

Adds support for provisioning an instance on a new dedicated host.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 26, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from 0cadb9a to 2dd765e Compare August 27, 2025 13:54
@punkwalker
Copy link
Contributor

punkwalker commented Aug 27, 2025 •
edited
Loading

Hi @rvanderp3,
Thank you for picking this up.
I know the PR is still in draft but I wanted to add some suggestion at the start. Hope you don't mind.

punkwalker
punkwalker reviewed Aug 27, 2025
View reviewed changes
@rvanderp3
Copy link
Contributor Author

Hi @rvanderp3, Thank you for picking this up. I know the PR is still in draft but I wanted to add some suggestion at the start. Hope you don't mind.

not at all, I appreciate the early feedback

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from 2dd765e to 92e2a20 Compare August 27, 2025 20:31
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
enxebre
enxebre reviewed Aug 28, 2025
View reviewed changes
@enxebre
Copy link
Member

enxebre commented Aug 28, 2025

covers #5599

@enxebre
Copy link
Member

enxebre commented Aug 28, 2025

@rvanderp3 thanks! this is looking great. I dropped some early feedback.

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from e9dc543 to c46e590 Compare August 28, 2025 20:21
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from 5834d9a to 40dcedc Compare September 10, 2025 17:23
punkwalker
punkwalker reviewed Sep 10, 2025
View reviewed changes
api/v1beta2/awsmachine_types.go
Comment on lines +289 to +284
// Tags to apply to the allocated dedicated host.
// +optional
Tags map[string]string `json:"tags,omitempty"`
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the same tags that are present on Machine under spec.additionalTags and default tags as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could for sure. will make that change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punkwalker Ive made the change to include tags specified in spec.additionalTags. I looked at including the default tags as well but it seemed odd to apply some of them to the dedicated host. For example, the role tag that would be attached to the machine is node and that was be propagated to the dedicate host. I assumed default tags meant those that would be applied to the machine but I may have misunderstood. What did you mean by "default tags"?

@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 3 times, most recently from fb9abd3 to d5a03c3 Compare September 12, 2025 14:15
@rvanderp3
Copy link
Contributor Author

/retest-required

1 similar comment
@rvanderp3
Copy link
Contributor Author

/retest-required

@rvanderp3
Copy link
Contributor Author

/unhold

aws-test appears to be failing due to VPC quota exhaustion

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2025
@rvanderp3
Copy link
Contributor Author

/retest-required

@rvanderp3
Copy link
Contributor Author

/hold

i need to look a bit closer, it does appear one of the new unit tests is failing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from d5a03c3 to 7d4ddc0 Compare September 15, 2025 18:37
@rvanderp3
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 4 times, most recently from 4a6ea38 to b4ca71d Compare September 18, 2025 17:37
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from d8cfe76 to c2fd570 Compare September 22, 2025 13:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2025
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch 2 times, most recently from 3422d6b to e55553a Compare September 23, 2025 18:54
@rvanderp3 rvanderp3 force-pushed the allocate-dedicated-hosts branch from e55553a to 26f35cf Compare September 23, 2025 20:07
@rvanderp3
Copy link
Contributor Author

/retest-required

1 similar comment
@rvanderp3
Copy link
Contributor Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo Awaiting requested review from damdo

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@faiq faiq Awaiting requested review from faiq

3 more reviewers

@enxebre enxebre enxebre left review comments

@mtulio mtulio mtulio left review comments

@punkwalker punkwalker punkwalker left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@nrb nrb

@damdo damdo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rvanderp3 @k8s-ci-robot @punkwalker @enxebre @damdo @mtulio @nrb