🐛 ROSA: Apply CAPI machinepool changes to ROSAMachinePool

[PanSpagetka]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Apply CAPI machinepool changes to ROSAMachinePool when ROSAMachinePool is not managed by (external) autoscaler.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

Apply CAPI machinepool changes to ROSAMachinePool

[k8s-ci-robot]

Hi @PanSpagetka. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nrb]

/ok-to-test

[serngawy]

one comment and can you add the reference for the min ROSAMachinePool num of replicas per zone in the PR description.

[serngawy]

We should add logic in the func shouldUpdateRosaReplicas if the user set the replica to 1 in the machinePool saying ROSAMachinePool must have at least 3 replica per zone and machinePool replica changes will be ignored

[PanSpagetka]

Setting 1 replica is ok, if there isnt the only machine pool. If there is the only one machine pool, number of replicas will not go lower than 2. If you try to set it to 1, reconcile with end with an error. I think that is OK behavior.

[serngawy]

hmm okay then, since we don't add default MP most likely we will not have this issue. We may re-visit this when we work on adding default MP.

[serngawy]

/lgtm

[nrb]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• exp/controllers/OWNERS [nrb]
• templates/OWNERS [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[PanSpagetka]

/test pull-cluster-api-provider-aws-test

[PanSpagetka]

@nrb Could you please review once more? I made some changes to fix the tests

[serngawy]

/lgtm