-
Notifications
You must be signed in to change notification settings - Fork 107
✨ Upgrade cluster-api to v1.11.0 #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upgrade cluster-api to v1.11.0 #880
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @PavanNeerudu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest pull-cluster-api-operator-e2e-main |
@PavanNeerudu: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-operator-e2e-main |
Hi @furkatgofurov7 , could you review the PR. I was able to resolve the failures in the last iterations. There is however a pipeline failure(pull-cluster-api-operator-apidiff-main) which is expected because this PR brings in changes from cluster-api conditions to the kubernetes conditions. Since the project is on alpha, do you think we can bypass this failure or suggest what we can do here? Thanks! |
Hey @furkatgofurov7 , checking in for reviews on the PR. |
@PavanNeerudu thanks for the PR, I'll take a closer look soon, but meanwhile can you please take care of adding |
Yes, |
Done. Updated in the latest commits. |
@PavanNeerudu Any news? It's blocking update to clusterctl 1.11 |
@PavanNeerudu hey, can you please address the outstanding minor comments and squash the commits? I'll defer the labelling until then, thank you! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have addressed the comments. Could you please take another pass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit:
Please squash commits once you resolve the last comments, otherwise LGTM, thank you. |
4ba2a94
to
17125f6
Compare
Sure, done. |
17125f6
to
60acb91
Compare
@furkatgofurov7 can you approve and merge the PR? Thanks! |
@PavanNeerudu golangci-lint is failing |
This commit upgrades the cluster-api-operator to use cluster-api v1.11.0 with the following major changes: - Updated all cluster-api dependencies from v1.10.4 to v1.11.0 - Migrated from cluster-api conditions helpers to k8s.io/apimachinery/pkg/api/meta - Updated condition handling to use conditions.Set instead of meta.SetStatusCondition - Fixed condition status comparisons for v1beta2 compatibility - Updated contract version to v1beta2 with major: 1, minor: 11 across all configurations - Fixed healthcheck controller to properly map deployment status to provider Ready condition - Added DeploymentAvailable reason constant for condition validation - Updated test infrastructure to handle CoreProvider naming constraints - Fixed CRD cleanup in E2E tests to preserve operator CRDs - Updated all test resources and configurations for v1.11.0 compatibility - Resolved linting issues and compilation errors - All unit tests and E2E tests now pass with v1.11.0 Breaking changes: - Requires cluster-api v1.11.0 or later - Uses v1beta2 API contract - Condition Reason field validation is stricter (must be non-empty and match regex pattern) Fixes #[issue-number] if applicable
60acb91
to
880b9c1
Compare
Thank you! /lgtm |
LGTM label has been added. Git tree hash: 13554306f69bfe002522cd10fc25f196561c56bd
|
@PavanNeerudu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
✨ Upgrade cluster-api to v1.11.0
What this PR does / why we need it:
This PR upgrades the cluster-api dependencies from v1.10.4 to v1.11.0, which includes several breaking changes that required significant code updates:
sigs.k8s.io/cluster-api
to v1.11.0 and related dependenciesv1beta1
tov1beta2
where applicableThis upgrade ensures compatibility with the latest cluster-api release and maintains all existing functionality while adopting the standardized Kubernetes condition handling patterns.
Testing:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes: #854