Skip to content

Conversation

praddy26
Copy link
Contributor

@praddy26 praddy26 commented Sep 20, 2025

Issue

Fixes #4341

Description

This PR adds documentation about the correct order of deletion for AWS Load Balancer Controller resources, particularly around Ingress and IngressClass resources. The issue arises when users delete IngressClass resources before deleting the associated Ingresses, resulting in orphaned Ingress resources that cannot be cleaned up without manual intervention.

Changes made:

  • Added a new section "Resource Cleanup Order" in docs/guide/ingress/ingress_class.md
  • Clearly documented the recommended order of deletion (Ingresses first, then IngressClass/IngressClassParams)
  • Explained why this order is important and the consequences of incorrect deletion order
  • Used consistent documentation style with existing content (MkDocs admonitions)
  • Added warning block to highlight potential issues
Screenshot 2025-09-20 at 6 06 51 PM

Checklist

  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested (verified documentation renders correctly with MkDocs)
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: praddy26
Once this PR has been reviewed and has the lgtm label, please assign shraddhabang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @praddy26. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 20, 2025
@praddy26 praddy26 changed the title Document update for order of deletion for ingress related resources Updated documentation to reflect the correct order of deletion for ingress-related resources Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of ingresses and ingress classes do not get eventual consistency if the ingress class is deleted first
2 participants