Skip to content

fix(python): add backward compatibility for SandboxClaim status.sandbox.Name#515

Open
kincoy wants to merge 1 commit intokubernetes-sigs:mainfrom
kincoy:fix/sandboxclaim-name-case-compatibility
Open

fix(python): add backward compatibility for SandboxClaim status.sandbox.Name#515
kincoy wants to merge 1 commit intokubernetes-sigs:mainfrom
kincoy:fix/sandboxclaim-name-case-compatibility

Conversation

@kincoy
Copy link
Copy Markdown

@kincoy kincoy commented Apr 3, 2026

Adds backward compatibility for status.sandbox.name in the Python client.

PR #440 renamed the field from Name to name but the change isn't released yet. Older controllers still return Name, breaking things for users (#505).

The code review bot in #440 actually recommended adding a fallback to check both fields, but it didn't make it into the final PR. This adds that fallback - it's just one line and lets the Python client work with any controller version.

Fixes #505

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 3, 2026

Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit 3d7bd64
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69cf872773398b0008d31013

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kincoy
Once this PR has been reviewed and has the lgtm label, please assign barney-s for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @kincoy!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @kincoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2026
@kincoy kincoy force-pushed the fix/sandboxclaim-name-case-compatibility branch from bd3b4e2 to 3d7bd64 Compare April 3, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:python-client cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] resolve_sandbox_name fails with Alibaba ACK due to case mismatch in sandbox status field

3 participants