fix(python): add backward compatibility for SandboxClaim status.sandbox.Name#515
fix(python): add backward compatibility for SandboxClaim status.sandbox.Name#515kincoy wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for agent-sandbox canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kincoy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @kincoy! |
|
Hi @kincoy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
bd3b4e2 to
3d7bd64
Compare
Adds backward compatibility for
status.sandbox.namein the Python client.PR #440 renamed the field from
Nametonamebut the change isn't released yet. Older controllers still returnName, breaking things for users (#505).The code review bot in #440 actually recommended adding a fallback to check both fields, but it didn't make it into the final PR. This adds that fallback - it's just one line and lets the Python client work with any controller version.
Fixes #505