Support extensions and custom controller flags in deploy-to-kube tool#511
Support extensions and custom controller flags in deploy-to-kube tool#511igooch wants to merge 3 commits intokubernetes-sigs:mainfrom
Conversation
|
@barney-s let me know if you'd prefer this broken down into separate PRs. |
✅ Deploy Preview for agent-sandbox canceled.
|
|
/lgtm |
|
/ok-to-test |
| container["args"] = [] | ||
| flags = flags_str.split() | ||
| for flag in flags: | ||
| if flag not in container["args"]: |
There was a problem hiding this comment.
We might need to enhance this logic in future, but I think it's a great start. (e.g. --v=2 => --v=8)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aditya-shantanu, igooch, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@igooch - Could you please investigate the e2e failures ? |
a1279fd to
df5e558
Compare
|
New changes are detected. LGTM label has been removed. |
|
@igooch: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR refactors the deployment tools to support optional extensions and custom controller configuration.
--extensionsflag to deploy the extensions resources to the cluster.--controller-argsflag to pass arbitrary arguments (e.g., --zap-log-level=debug) directly to the controller container.kubectl patchlogic in the Makefile with a native--extensionsflag in the deployment script.This makes the
make deploy-kindand./dev/tools/deploy-to-kubetargets much more helpful when developing for the extensions controllers.