Skip to content

Support extensions and custom controller flags in deploy-to-kube tool#511

Open
igooch wants to merge 3 commits intokubernetes-sigs:mainfrom
igooch:deploy-extensions
Open

Support extensions and custom controller flags in deploy-to-kube tool#511
igooch wants to merge 3 commits intokubernetes-sigs:mainfrom
igooch:deploy-extensions

Conversation

@igooch
Copy link
Copy Markdown
Contributor

@igooch igooch commented Apr 2, 2026

This PR refactors the deployment tools to support optional extensions and custom controller configuration.

  • Breaks up the current deploy-to-kube into separate gather, process, and apply stages.
  • Adds a --extensions flag to deploy the extensions resources to the cluster.
  • Adds a --controller-args flag to pass arbitrary arguments (e.g., --zap-log-level=debug) directly to the controller container.
  • Replaces the manual kubectl patch logic in the Makefile with a native --extensions flag in the deployment script.

This makes the make deploy-kind and ./dev/tools/deploy-to-kube targets much more helpful when developing for the extensions controllers.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2026
@igooch
Copy link
Copy Markdown
Contributor Author

igooch commented Apr 2, 2026

@barney-s let me know if you'd prefer this broken down into separate PRs.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 2, 2026

Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit df5e558
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69d029e5d18f1b0008e42886

@aditya-shantanu
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2026
@aditya-shantanu
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 2, 2026
container["args"] = []
flags = flags_str.split()
for flag in flags:
if flag not in container["args"]:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to enhance this logic in future, but I think it's a great start. (e.g. --v=2 => --v=8)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aditya-shantanu, igooch, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@barney-s
Copy link
Copy Markdown
Contributor

barney-s commented Apr 3, 2026

/retest

@barney-s
Copy link
Copy Markdown
Contributor

barney-s commented Apr 3, 2026

@igooch - Could you please investigate the e2e failures ?

@igooch igooch force-pushed the deploy-extensions branch from a1279fd to df5e558 Compare April 3, 2026 20:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@igooch: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-agent-sandbox-e2e-test df5e558 link true /test presubmit-agent-sandbox-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. next-step:contributor ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants