feat: Add fgprof debug endpoint for Off-CPU time analysis#486
feat: Add fgprof debug endpoint for Off-CPU time analysis#486dongjiang1989 wants to merge 3 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: dongjiang <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongjiang1989 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for agent-sandbox canceled.
|
|
Its a single maintainer profiler that exposes significant information. @justinsb FYI |
|
Yeah, it's a good question. It is MIT licensed, and it does look to have been updated recently, so I think abandonment risk is low. I think if we hid this behind a go build tag, then it would be very easy to accept. Behind a flag would also work. My biggest concern is that we accidentally consider this part of our "feature set" and then we can never remove it, even if go implements something similar. And it does seem like a good feature, so I both want it in this library and I imagine go might one day add it! @dongjiang1989 WDYT - is this something we should ship to everyone? Or is it more like the race detector ( #331 ) where we want to enable it in our CI but it's not as valuable for end-users? |
Thanks @justinsb @barney-s |
Signed-off-by: dongjiang <[email protected]>
Add fgprof debug endpoint for Off-CPU time analysis.