Skip to content
This repository was archived by the owner on Apr 12, 2022. It is now read-only.

Conversation

@shivramsrivastava
Copy link
Contributor

This PR add a new informer to view other pods not scheduled by Poseidon.
This information is required for resource calculation of node and also for max-pods feature.
This PR also includes the max-pods feature.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shivramsrivastava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2018
@shivramsrivastava
Copy link
Contributor Author

/assign @deepak-vij

@deepak-vij
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2018
@deepak-vij
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2018
@deepak-vij
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2018
@m1093782566
Copy link

cc @islinwb

Can you pick #112 up when this PR goes in.

@islinwb
Copy link
Contributor

islinwb commented Oct 10, 2018

@m1093782566 This PR has realized it.

This PR also includes the max-pods feature.

@m1093782566
Copy link

Oh, I missed that.

Great!

@shivramsrivastava
Copy link
Contributor Author

@m1093782566 @islinwb
Please don't close #112
I will cherry-pick the E2E test case from that PR.

@shivramsrivastava
Copy link
Contributor Author

/test ci-poseidon-e2e-gce

@shivramsrivastava
Copy link
Contributor Author

/retest

1 similar comment
@shivramsrivastava
Copy link
Contributor Author

/retest

@m1093782566
Copy link

Error logs of test:

I1011 10:45:17.862] 
I1011 10:45:17.862] • Failure [16.822 seconds]
I1011 10:45:17.862] Poseidon
I1011 10:45:17.863] /go/src/github.com/kubernetes-sigs/poseidon/test/e2e/poseidon_integration.go:38
I1011 10:45:17.863]   Poseidon [Predicates]
I1011 10:45:17.863]   /go/src/github.com/kubernetes-sigs/poseidon/test/e2e/poseidon_integration.go:297
I1011 10:45:17.863]     should validates resource limits of pods that are allowed to run  [It]
I1011 10:45:17.863]     /go/src/github.com/kubernetes-sigs/poseidon/test/e2e/poseidon_integration.go:314
I1011 10:45:17.863] 
I1011 10:45:17.863]     Expected error:
I1011 10:45:17.863]         <*errors.errorString | 0xc000335ba0>: {
I1011 10:45:17.863]             s: "pod ran to completion",
I1011 10:45:17.863]         }
I1011 10:45:17.863]         pod ran to completion
I1011 10:45:17.863]     not to have occurred
I1011 10:45:17.863] 
I1011 10:45:17.864]     /go/src/github.com/kubernetes-sigs/poseidon/test/e2e/poseidon_integration.go:422
I1011 10:45:17.864] ------------------------------

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@shivramsrivastava
Copy link
Contributor Author

Will be closing the PR for now.
Some issues with resource calculation and max-pods feature, will investigate and create a new PR soon.

@k8s-ci-robot
Copy link
Contributor

@shivramsrivastava: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci-poseidon-e2e-gce f2cdccf link /test ci-poseidon-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants