Update dependencies #389
Update dependencies #389
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/cc @rifelpet |
hakman
force-pushed
the
update-deps
branch
3 times, most recently
from
77fc54d to
29ee0e9
Compare
etcd-manager/images/BUILD
Outdated
| architecture = select({ | ||
| "@io_bazel_rules_go//go/platform:amd64": "amd64", | ||
| "@io_bazel_rules_go//go/platform:arm64": "arm64", | ||
| }), |
There was a problem hiding this comment.
why are these being removed? have we tested that the resulting images are multi-arch?
perhaps we should follow the archived rules_docker suggestion and move to rules_oci
There was a problem hiding this comment.
I am just experimenting. Bazel anything is huge pain. Tests are not yet passing due to build errors.
Not sure I want to move to rules_oci, just to strip it away in a few months.
There was a problem hiding this comment.
Went back to the basics and it's good to go now.
@rifelpet Could you take another look?
There was a problem hiding this comment.
BTW, for some reason this did not compile with Go 1.22...
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.