-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the Python sockets when the Websocket closes #2316
base: master
Are you sure you want to change the base?
Conversation
This allows the client to detect when the connection has been interrupted
The committers listed above are authorized under a signed CLA. |
Welcome @anvilpete! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anvilpete The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If the websocket connection to the k8s API server is closed for any reason, the library currently throws a
WebSocketConnectionClosedException
in the PortForward proxy thread and hangs.This PR catches this exception and closes the Python-side local sockets associated with the websocket. This lets the client application detect that the connection has been interrupted.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: