-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): pass client from main #2308
base: master
Are you sure you want to change the base?
Conversation
small nit -- the other 2 functions also accept client
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BozhidarManev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @BozhidarManev! |
@@ -51,8 +51,7 @@ def create_deployment(apps_v1_api): | |||
) | |||
|
|||
|
|||
def create_service(): | |||
core_v1_api = client.CoreV1Api() | |||
def create_service(core_v1_api): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the CLA
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
small nit -- the other 2 functions also accept a client
Which issue(s) this PR fixes:
Fixes # N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: