Implement Watch #24
Implement Watch #24
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
looks that there is one example, the other file is deleted, is it intentional? could you please squash the commits? |
k8s-ci-robot
added
size/L
|
@yliaog fixed and squashed. Sorry for the noise. |
| if err != nil { | ||
| t.Errorf("Unexpeceted non-nil: %v", err) | ||
| } | ||
| ns, ok := result.Object.(*V1Namespace) |
There was a problem hiding this comment.
result.Type is not checked
| t.Errorf("unexpected value (%d): %v", ix, out[ix]) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
what about an error case, errs is not empty
| } | ||
|
|
||
| func (w *WatchClient) Connect(ctx context.Context) (<-chan *Result, <-chan error, error) { | ||
| url := w.Cfg.Scheme + "://" + w.Cfg.Host + w.Path + "?watch=true" |
There was a problem hiding this comment.
what about supporting watch from a specific resource version?
| if len(line) == 0 { | ||
| return nil, nil | ||
| } | ||
| decoder := json.NewDecoder(strings.NewReader(line)) |
There was a problem hiding this comment.
what about protobuf encoding?
| } | ||
| } | ||
|
|
||
| func TestMultiDecode(t *testing.T) { |
There was a problem hiding this comment.
how about a test for Connect?
|
comments addressed, please re-check. Thanks! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.