Add support for multiple nics with vmware cloud director in the UI #7452

4ch3los · 2025-06-25T15:51:25Z

What this PR does / why we need it:
This PR completes the feature of multiple nics for vmware cloud director workers(introduced in kubermatic/machine-controller#1941 & kubermatic/operating-system-manager#471 ). By Allowing to define additional networks, which will also be added to the machinedeployment

Which issue(s) this PR fixes:

What type of PR is this?
/kind feature

Special notes for your reviewer:
This PR depends on kubermatic/machine-controller#1941 & kubermatic/operating-system-manager#471

Does this PR introduce a user-facing change? Then add your Release Note here:

You can now define multiple Networks for nodes of your vmware cloud director machinedeployment

Documentation:

NONE

Signed-off-by: Kai Fink <[email protected]>

kubermatic-bot · 2025-06-25T15:51:36Z

Hi @4ch3los. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

KhizerRehan

Minor Feedback (PTAL)

modules/web/src/app/node-data/basic/provider/vmware-cloud-director/template.html

modules/web/proxy-sva.conf.cjs

modules/web/src/app/node-data/basic/provider/vmware-cloud-director/component.ts

modules/api/pkg/resources/machine/common.go

modules/api/pkg/api/v1/types.go

Waseem826 · 2025-08-22T07:57:58Z

/ok-to-test

…ctor/template.html Co-authored-by: Khizer Rehan <[email protected]> Signed-off-by: Kai Fink <[email protected]>

…ctor/component.ts Co-authored-by: Khizer Rehan <[email protected]> Signed-off-by: Kai Fink <[email protected]>

Signed-off-by: Kai Fink <[email protected]>

KhizerRehan · 2025-09-25T06:27:03Z

@4ch3los can you run make update-codegen inside the api folder?

4ch3los · 2025-09-25T08:55:08Z

@4ch3los can you run make update-codegen inside the api folder?

@KhizerRehan
Yeah sure, but i guess we wont get the build + tests running until the machine-controller changes are released(kubermatic/machine-controller#1941) and the dependency can be updated

Signed-off-by: Kai Fink <[email protected]>

kubermatic-bot · 2025-11-03T16:07:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign khizerrehan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Kai Fink <[email protected]>

4ch3los · 2025-11-04T16:54:33Z

Hey There! OSM and Machinecontroller changes have been released and i updated the dependencies, client, codegen etc. the only thing failing is the unit tests, but im not exactly sure why, does anybody of you have a hint? @KhizerRehan @Waseem826
Thanks!

KhizerRehan

Minor Feedback

KhizerRehan · 2025-11-05T14:51:10Z

modules/web/src/app/node-data/basic/provider/vmware-cloud-director/component.ts


  private _initForm(): void {
    const values = this._nodeDataService.nodeData.spec.cloud.vmwareclouddirector;
    const defaults = getDefaultNodeProviderSpec(NodeProvider.VMWARECLOUDDIRECTOR) as VMwareCloudDirectorNodeSpec;


Please add default value for additional network in getDefaultNodeProviderSpec method under case NodeProvider.VMWARECLOUDDIRECTOR:

additionalNetworks: []

KhizerRehan · 2025-11-05T15:03:08Z

/test pre-dashboard-api-unit

Copilot

Pull Request Overview

This PR adds support for configuring multiple network interfaces for VMware Cloud Director worker nodes in the UI, complementing backend support added in related machine-controller and operating-system-manager PRs. Users can now specify additional networks beyond the primary network when creating machine deployments.

Key Changes:

Added additionalNetworks field to VMware Cloud Director node specifications across frontend and backend
Implemented UI controls for selecting multiple networks with validation to prevent duplicate selection
Updated network configuration logic to handle both primary and additional networks as a unified list

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
modules/web/src/app/shared/entity/node.ts	Added `additionalNetworks` array field to VMwareCloudDirectorNodeSpec
modules/web/src/app/node-data/basic/provider/vmware-cloud-director/template.html	Added multi-select dropdown for additional networks with conditional display
modules/web/src/app/node-data/basic/provider/vmware-cloud-director/component.ts	Implemented logic for managing additional networks selection and synchronization
modules/api/pkg/resources/machine/common.go	Updated provider config generation to merge primary and additional networks into unified list
modules/api/pkg/machine/convert.go	Added conversion logic between machine spec networks and API node spec format
modules/api/pkg/api/v1/types.go	Added `AdditionalNetworks` field to VMwareCloudDirectorNodeSpec type
modules/api/pkg/test/e2e/utils/apiclient/models/*.go	Regenerated OpenAPI client models for new fields and Kubernetes API updates
modules/api/go.mod	Updated dependencies including k8s.io, controller-runtime, and related libraries
modules/api/cmd/kubermatic-api/swagger.json	Updated swagger specification with new field definitions
modules/api/pkg/test/e2e/utils/kubernetes.go	Updated RESTClientForGVK call signature for new API version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-05T15:04:03Z

modules/web/src/app/node-data/basic/provider/vmware-cloud-director/component.ts

    const networkControl = this.form.get(Controls.Network);
+    const additionalNetworksControl = this.form.get(Controls.AdditionalNetworks);
+
+    additionalNetworksControl.setValue(additionalNetworksControl.value.filter(n => this.networks.includes(n)));


Potential nil reference if additionalNetworksControl.value is null or undefined. Add a null check before calling filter: additionalNetworksControl.value?.filter(n => this.networks.includes(n)) ?? []

Suggested change

additionalNetworksControl.setValue(additionalNetworksControl.value.filter(n => this.networks.includes(n)));

additionalNetworksControl.setValue(additionalNetworksControl.value?.filter(n => this.networks.includes(n)) ?? []);

KhizerRehan · 2025-11-06T07:42:12Z

Hi @4ch3los, based on the logs it doesn’t seem like this PR caused the pipeline failure. However, something has changed that’s affecting this line, as all failures point to it.

Expected VS Got

Example

KhizerRehan · 2025-11-07T06:52:44Z

FYI: @4ch3los

The following test case failures are due to dependency updates the preference: {} property was removed during the migration to Kubernetes v1.34. However, there’s one PR that needs to be merged first. Once that’s done, rebasing onto the latest main branch should resolve the pipeline failures.

Ref: #7692

KhizerRehan · 2025-11-10T10:45:40Z

@4ch3los can you rebase your PR with latest main branch?

# Conflicts: # modules/api/go.mod # modules/api/go.sum

kubermatic-bot · 2025-11-18T16:42:40Z

@4ch3los: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pre-dashboard-web-integration-tests-ce	`69c2b8e`	link	true	`/test pre-dashboard-web-integration-tests-ce`
pre-dashboard-web-integration-tests	`69c2b8e`	link	true	`/test pre-dashboard-web-integration-tests`
pre-dashboard-api-e2e	`69c2b8e`	link	true	`/test pre-dashboard-api-e2e`

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

4ch3los · 2025-11-18T16:56:16Z

@4ch3los can you rebase your PR with latest main branch?

Did it, and seems that the pipeline failed cause of some temporary conditions again

Add support for multiple nics with vmware cloud director

508b8f9

Signed-off-by: Kai Fink <[email protected]>

kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2025

csengerszabo requested a review from kron4eg July 2, 2025 09:10

Merge branch 'refs/heads/main' into feat/vcloud-multi-nic

bb6d36b

KhizerRehan reviewed Aug 22, 2025

View reviewed changes

kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2025

4ch3los and others added 3 commits August 26, 2025 10:36

Update modules/web/src/app/node-data/basic/provider/vmware-cloud-dire…

f828765

…ctor/template.html Co-authored-by: Khizer Rehan <[email protected]> Signed-off-by: Kai Fink <[email protected]>

Update modules/web/src/app/node-data/basic/provider/vmware-cloud-dire…

31d34fb

…ctor/component.ts Co-authored-by: Khizer Rehan <[email protected]> Signed-off-by: Kai Fink <[email protected]>

Remove unneeded file

e715901

Signed-off-by: Kai Fink <[email protected]>

4ch3los added 2 commits September 25, 2025 11:06

Updated codegen for adjusted api

dbf9cea

Signed-off-by: Kai Fink <[email protected]>

Merge branch 'main' into feat/vcloud-multi-nic

4494741

4ch3los added 7 commits November 3, 2025 23:17

Update machine-controller and operating-system-manager

aadc85b

Signed-off-by: Kai Fink <[email protected]>

Update api dependencies

6c9fd41

Signed-off-by: Kai Fink <[email protected]>

Update api dependencies(kube-openapi)

6f0dbf5

Signed-off-by: Kai Fink <[email protected]>

Fix test method call

6ad1cc5

Signed-off-by: Kai Fink <[email protected]>

Update swagger

62d0b49

Signed-off-by: Kai Fink <[email protected]>

Update api client

a51559e

Signed-off-by: Kai Fink <[email protected]>

Missing file from swagger gen

9d75af3

Signed-off-by: Kai Fink <[email protected]>

kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2025

KhizerRehan reviewed Nov 5, 2025

View reviewed changes

KhizerRehan requested a review from Copilot November 5, 2025 15:03

Copilot AI reviewed Nov 5, 2025

View reviewed changes

Merge branch 'main' into feat/vcloud-multi-nic

69c2b8e

# Conflicts: # modules/api/go.mod # modules/api/go.sum

kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2025

kron4eg removed their request for review November 18, 2025 17:45

	additionalNetworksControl.setValue(additionalNetworksControl.value.filter(n => this.networks.includes(n)));
	additionalNetworksControl.setValue(additionalNetworksControl.value?.filter(n => this.networks.includes(n)) ?? []);

Add support for multiple nics with vmware cloud director in the UI #7452

Are you sure you want to change the base?

Add support for multiple nics with vmware cloud director in the UI #7452

Uh oh!

Conversation

4ch3los commented Jun 25, 2025

Which issue(s) this PR fixes:

Uh oh!

kubermatic-bot commented Jun 25, 2025

Uh oh!

KhizerRehan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Waseem826 commented Aug 22, 2025

Uh oh!

KhizerRehan commented Sep 25, 2025

Uh oh!

4ch3los commented Sep 25, 2025

Uh oh!

kubermatic-bot commented Nov 3, 2025

Uh oh!

4ch3los commented Nov 4, 2025

Uh oh!

KhizerRehan left a comment

Choose a reason for hiding this comment

Uh oh!

KhizerRehan Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

KhizerRehan commented Nov 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

KhizerRehan commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KhizerRehan commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KhizerRehan commented Nov 10, 2025

Uh oh!

kubermatic-bot commented Nov 18, 2025

Uh oh!

4ch3los commented Nov 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KhizerRehan commented Nov 6, 2025 •

edited

Loading

KhizerRehan commented Nov 7, 2025 •

edited

Loading