runtimes: add restricted PSS security contexts#3702
Draft
danish9039 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the Torch distributed Trainer runtime manifests and matching Helm templates restricted-PSS compatible.
It adds pod and container security contexts for the Torch distributed runtime and the data-cache variant, and updates Helm unit tests to cover those fields.
The data-cache
dataset-initializerkeeps the image default working directory because the image entrypoint runspython -m pkg.initializers.datasetfrom its/appmodule root. The trainingnodecontainers keepworkingDir: /tmpfor non-root runtime compatibility.Validation:
make helm-unittestpassed: 18 suites / 109 testskustomize build manifests/base/runtimeskustomize build manifests/base/runtimes/data-cachehelm templatefrom a temporary chart copy after dependency buildgit diff --checkWhich issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Related to kubeflow/community-distribution#3487
Checklist: