Restore defaultProviders.metrics in oauth2-proxy istio mesh config#3532
Conversation
The istio-external-auth-patches component replaces the entire istio mesh config and dropped defaultProviders.metrics: [prometheus], which the base istio install ships. Without it istiod stops injecting the istio.stats telemetry filter, so istio_requests_total is never produced and Kiali graphs stay empty. Restore the field to match the base install. Signed-off-by: noisonnoiton <noisonnoiton@gmail.com>
|
Welcome to the Kubeflow Community Distribution Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
There was a problem hiding this comment.
Pull request overview
This pull request restores the missing defaultProviders.metrics: [prometheus] stanza in the Istio mesh configuration rendered by the istio-external-auth-patches component, ensuring that the oauth2-proxy extensionProviders patch remains aligned with the base Istio installation behavior and that telemetry metrics such as istio_requests_total are produced again.
Changes:
- Add back
defaultProviders.metrics: - prometheusto themeshconfiguration string in the patchedistioConfigMap.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✏️ Summary of Changes
The
istio-external-auth-patchescomponent replaces the entire istio meshconfig string in the
istioConfigMap (istio-system) to add the oauth2-proxyextensionProviders. In doing so it droppeddefaultProviders.metrics: [prometheus], which the base istio install ships(
common/istio/istio-install/base/install.yaml).Without
defaultProviders.metrics, istiod stops injecting theistio.statstelemetry filter into the sidecar listeners. As a result
istio_requests_totalis never produced, Prometheus scrapes empty telemetry, and Kiali traffic graphs
stay empty even though the mesh is healthy and serving traffic.
Istio standard telemetry metrics (including istio_requests_total) are no longer emitted.
This restores the three missing lines so the patched mesh config matches the
base install:
Verification:
Before: no
defaultProvidersin the rendered istio ConfigMap.After:
defaultProviders.metrics: [prometheus]present alongside theoauth2-proxy
extensionProviders.📦 Dependencies
None.
🐛 Related Issues
None. Straightforward regression fix restoring parity with the base istio
install configuration.
✅ Contributor Checklist