Skip to content

Restore defaultProviders.metrics in oauth2-proxy istio mesh config#3532

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
noisonnoiton:fix/istio-telemetry-defaultproviders
Jul 6, 2026
Merged

Restore defaultProviders.metrics in oauth2-proxy istio mesh config#3532
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
noisonnoiton:fix/istio-telemetry-defaultproviders

Conversation

@noisonnoiton

@noisonnoiton noisonnoiton commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✏️ Summary of Changes

The istio-external-auth-patches component replaces the entire istio mesh
config string in the istio ConfigMap (istio-system) to add the oauth2-proxy
extensionProviders. In doing so it dropped defaultProviders.metrics: [prometheus], which the base istio install ships
(common/istio/istio-install/base/install.yaml).

Without defaultProviders.metrics, istiod stops injecting the istio.stats
telemetry filter into the sidecar listeners. As a result istio_requests_total
is never produced, Prometheus scrapes empty telemetry, and Kiali traffic graphs
stay empty even though the mesh is healthy and serving traffic.
Istio standard telemetry metrics (including istio_requests_total) are no longer emitted.

This restores the three missing lines so the patched mesh config matches the
base install:

    defaultProviders:
      metrics:
      - prometheus

Verification:

kustomize build example \
  | yq 'select(.kind=="ConfigMap" and .metadata.name=="istio") | .data.mesh' \
  | grep -A2 defaultProviders

Before: no defaultProviders in the rendered istio ConfigMap.
After: defaultProviders.metrics: [prometheus] present alongside the
oauth2-proxy extensionProviders.

📦 Dependencies

None.

🐛 Related Issues

None. Straightforward regression fix restoring parity with the base istio
install configuration.

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

The istio-external-auth-patches component replaces the entire istio mesh
config and dropped defaultProviders.metrics: [prometheus], which the base
istio install ships. Without it istiod stops injecting the istio.stats
telemetry filter, so istio_requests_total is never produced and Kiali
graphs stay empty. Restore the field to match the base install.

Signed-off-by: noisonnoiton <noisonnoiton@gmail.com>
Copilot AI review requested due to automatic review settings July 6, 2026 00:07
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Welcome to the Kubeflow Community Distribution Repository

Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community.

Before making more PRs:
Please ensure your PR follows our Contributing Guide.
Please also be aware that many components are synchronized from upstream via the scripts in /scripts.
So in some cases you have to fix the problem in the upstream repositories first, but you can use a PR against kubeflow/community-distribution to test the platform integration.

Community Resources:

Thanks again for helping to improve Kubeflow.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request restores the missing defaultProviders.metrics: [prometheus] stanza in the Istio mesh configuration rendered by the istio-external-auth-patches component, ensuring that the oauth2-proxy extensionProviders patch remains aligned with the base Istio installation behavior and that telemetry metrics such as istio_requests_total are produced again.

Changes:

  • Add back defaultProviders.metrics: - prometheus to the mesh configuration string in the patched istio ConfigMap.

@juliusvonkohout

Copy link
Copy Markdown
Member

/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit c71e745 into kubeflow:master Jul 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants