feat: support tasks on the staged update delete stage by Copilot · Pull Request #813 · kubefleet-dev/kubefleet

Copilot · 2026-08-12T23:52:49Z

The implicit delete stage could remove workloads immediately, bypassing the Approval and TimedWait gates available to update stages. This prevented controlled decommissioning of clusters leaving a placement.

API
- Add optional deleteStageTasks to both scoped update strategies.
- Support existing Approval and TimedWait task types.
- Validate task count, uniqueness, and wait duration.
```
spec:
  stages: [...]
  deleteStageTasks:
    - type: TimedWait
      waitTime: 30m
    - type: Approval
```
Execution
- Initialize delete-task status in the update run snapshot.
- Reuse concurrent after-stage task evaluation and approval requests.
- Delete bindings only after every configured task passes.
- Preserve immediate deletion when tasks are unset.
Lifecycle
- Evaluate gates only before deletion begins.
- Allow runs waiting on delete tasks to stop without deleting gated bindings.
- Support cluster-scoped and namespaced runs.

Fixes Support before/after stage tasks on the StagedUpdateRun delete stage #746

Co-authored-by: ytimocin <5220939+ytimocin@users.noreply.github.com>

Yetkin Timocin (ytimocin) · 2026-08-13T00:23:52Z


 	// UpdateRunDeleteStageName is the name of delete stage in the staged update run.
 	UpdateRunDeleteStageName = FleetPrefix + "deleteStage"
+	// UpdateRunDeleteStageLabelValue is the label value used for the delete stage.


nit: extra line before this. follow the file structure.

Yetkin Timocin (ytimocin) · 2026-08-13T00:24:45Z


 	// AfterStageApprovalTaskNameFmt is the format of the after stage approval task name.
 	AfterStageApprovalTaskNameFmt = "%s-after-%s"
+	// DeleteStageApprovalTaskNameFmt is the format of the delete stage approval task name.


nit: extra line before this. follow the file structure.

Yetkin Timocin (ytimocin) · 2026-08-13T00:25:58Z

 	// AfterStageApprovalTaskNameFmt is the format of the after stage approval task name.
 	AfterStageApprovalTaskNameFmt = "%s-after-%s"
+	// DeleteStageApprovalTaskNameFmt is the format of the delete stage approval task name.
+	DeleteStageApprovalTaskNameFmt = "%s-after-delete-stage"


What is the difference between AfterStageApprovalTaskNameFmt and AfterStageApprovalTaskNameFmt? Why can't we have one generic? Names don't make that much sense.

AfterStageApprovalTaskNameFmt sounds generic like after any stage and that makes me think that Delete is also a stage, right?

Yetkin Timocin (ytimocin) · 2026-08-13T00:26:37Z

+	// +kubebuilder:validation:XValidation:rule="!self.exists(e, e.type == 'Approval' && has(e.waitTime))",message="DeleteStageTaskType is Approval, waitTime is not allowed"
+	// +kubebuilder:validation:XValidation:rule="!self.exists(e, e.type == 'TimedWait' && !has(e.waitTime))",message="DeleteStageTaskType is TimedWait, waitTime is required"
+	// +kubebuilder:validation:XValidation:rule="!self.exists(e, e.type == 'TimedWait' && has(e.waitTime) && duration(e.waitTime) <= duration('0s'))",message="DeleteStageTaskType is TimedWait, waitTime must be greater than zero"
+	DeleteStageTasks []StageTask `json:"deleteStageTasks,omitempty"`


Same comment as above. Why can't we have something generic and not specific to the Delete stage?

Yetkin Timocin (ytimocin) · 2026-08-13T00:27:30Z

 				}
 			}
 		}
+		for i := range updateRunStatus.UpdateStrategySnapshot.DeleteStageTasks {


Same question as above about being generic or not? Could we use an interface pattern for this?

Just a suggestion. Doesn't mean that we should use.

Copilot

Pull request overview

Adds approval and timed-wait gates before staged-update deletion, supporting controlled workload decommissioning.

Changes:

Adds validated deleteStageTasks API fields and generated artifacts.
Gates cluster-scoped and namespaced binding deletion on configured tasks.
Allows gated deletion stages to stop without deleting bindings.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`test/apis/placement/v1beta1/api_validation_integration_test.go`	Tests delete-task validation.
`pkg/controllers/updaterun/stop.go`	Corrects gated-stage stopping.
`pkg/controllers/updaterun/stop_test.go`	Tests stopping before deletion.
`pkg/controllers/updaterun/initialization.go`	Initializes delete-task status.
`pkg/controllers/updaterun/initialization_integration_test.go`	Verifies initialization.
`pkg/controllers/updaterun/execution.go`	Evaluates gates before deletion.
`pkg/controllers/updaterun/execution_test.go`	Tests task evaluation and deletion behavior.
`pkg/controllers/updaterun/execution_integration_test.go`	Tests approval gates for both scopes.
`pkg/controllers/updaterun/controller.go`	Sanitizes approval task snapshots.
`pkg/controllers/updaterun/controller_test.go`	Tests snapshot sanitization.
`config/crd/bases/placement.kubernetes-fleet.io_stagedupdatestrategies.yaml`	Adds namespaced strategy schema.
`config/crd/bases/placement.kubernetes-fleet.io_stagedupdateruns.yaml`	Adds namespaced snapshot schema.
`config/crd/bases/placement.kubernetes-fleet.io_clusterstagedupdatestrategies.yaml`	Adds cluster strategy schema.
`config/crd/bases/placement.kubernetes-fleet.io_clusterstagedupdateruns.yaml`	Adds cluster snapshot schema.
`apis/placement/v1beta1/zz_generated.deepcopy.go`	Deep-copies delete tasks.
`apis/placement/v1beta1/stageupdate_types.go`	Defines the new API field.
`apis/placement/v1beta1/commons.go`	Adds delete-stage constants.
`.github/.copilot/breadcrumbs/2026-08-12-2353-delete-stage-tasks.md`	Records implementation decisions.

Files not reviewed (1)

apis/placement/v1beta1/zz_generated.deepcopy.go: Generated file

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

 	updateRunRef := klog.KObj(updateRun)
 	updateRunStatus := updateRun.GetUpdateRunStatus()
 	existingDeleteStageStatus := updateRunStatus.DeletionStageStatus
+	if existingDeleteStageStatus.StartTime == nil {


Initial plan

212698b

Copilot AI assigned Copilot and Yetkin Timocin (ytimocin) Aug 12, 2026

Copilot started work on behalf of Yetkin Timocin (ytimocin) August 12, 2026 23:53 View session

Copilot AI linked an issue Aug 12, 2026 that may be closed by this pull request

Support before/after stage tasks on the StagedUpdateRun delete stage #746

Open

Copilot AI and others added 4 commits August 13, 2026 00:04

feat: gate delete stage with configured tasks

1d37f23

Co-authored-by: ytimocin <5220939+ytimocin@users.noreply.github.com>

fix: avoid reevaluating delete gates after start

00d38c1

Co-authored-by: ytimocin <5220939+ytimocin@users.noreply.github.com>

fix: stop safely while delete stage is gated

908d930

Co-authored-by: ytimocin <5220939+ytimocin@users.noreply.github.com>

chore: complete delete stage task breadcrumb

a3ed222

Co-authored-by: ytimocin <5220939+ytimocin@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Support before/after stage tasks on delete stage~~ feat: support tasks on the staged update delete stage Aug 13, 2026

Copilot AI requested a review from Yetkin Timocin (ytimocin) August 13, 2026 00:25

Copilot finished work on behalf of Yetkin Timocin (ytimocin) August 13, 2026 00:25

Yetkin Timocin (ytimocin) reviewed Aug 13, 2026

View reviewed changes

Yetkin Timocin (ytimocin) requested review from Britania Rodriguez Reyes (britaniar) and a balanced review from Copilot August 13, 2026 01:08

Copilot started reviewing on behalf of Yetkin Timocin (ytimocin) August 13, 2026 01:09 View session

Copilot AI reviewed Aug 13, 2026

View reviewed changes

Comment thread pkg/controllers/updaterun/execution.go

updateRunRef := klog.KObj(updateRun)

updateRunStatus := updateRun.GetUpdateRunStatus()

existingDeleteStageStatus := updateRunStatus.DeletionStageStatus

if existingDeleteStageStatus.StartTime == nil {

Navigation Menu

Uh oh!

feat: support tasks on the staged update delete stage - #813

feat: support tasks on the staged update delete stage#813
Yetkin Timocin (ytimocin) with Copilot wants to merge 5 commits into
mainfrom
copilot/support-before-after-stage-tasks

Copilot AI commented Aug 12, 2026 •

edited

Loading

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Yetkin Timocin (ytimocin) Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Aug 12, 2026 •

edited

Loading