Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sedna controller(Joint Inference and Federated Learning) proposal #453

Closed

Conversation

SherlockShemol
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
update sedna controller(Joint Inference and Federated Learning) proposal
Which issue(s) this PR fixes:

Fixes #

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jaypume after the PR has been reviewed.
You can assign the PR to them by writing /assign @jaypume in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2024
@tangming1996
Copy link
Contributor

Please optimize all the figures in the proposal. Currently, these figures look too large and not very coordinated. The color of the figures had better be light colors. Dark colors look very glaring. The color of each module in the figure should be meaningful and not just for coloring. You can learn from classmate Yuda's proposal: https://github.com/kubeedge/ianvs/blob/main/docs/proposals/algorithms/federated-class-incremental-learning/Federated%20Class-Incremental%20and%20Semi-Supervised%20learning%20Proposal.md.

@tangming1996
Copy link
Contributor

The content of this PR is submitted to 448.

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@SherlockShemol SherlockShemol deleted the ji-fl-proposal-update branch November 2, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants