fix: probe command #468
Open
fix: probe command #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daemon1024 @DelusionalOptimist @Prateeknandle please review :) |
This was referenced Nov 15, 2024
daemon1024
reviewed
Dec 13, 2024
Signed-off-by: mrrishi <[email protected]> Signed-off-by: jokestax <[email protected]>
Signed-off-by: mrrishi <[email protected]> Signed-off-by: jokestax <[email protected]>
Signed-off-by: Rishikesh <[email protected]> Signed-off-by: jokestax <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]> Signed-off-by: jokestax <[email protected]>
Signed-off-by: Prateek <[email protected]> Signed-off-by: jokestax <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]> Signed-off-by: jokestax <[email protected]>
Signed-off-by: jokestax <[email protected]>
Signed-off-by: mrrishi <[email protected]> Signed-off-by: jokestax <[email protected]>
Aryan-sharma11
requested changes
Jan 6, 2025
| } | ||
| return false | ||
| } | ||
|
|
||
| func sliceToSet(mySlice []string) mapset.Set[string] { | ||
| mySet := mapset.NewSet[string]() | ||
| for _, ele := range mySlice { | ||
| if len(ele) >= 10 && ele[0:9] == "namespace" { |
There was a problem hiding this comment.
why do we need this check?
Comment on lines
+814
to
+818
| /* | ||
| { | ||
| "policy_name": map[string][]string | ||
| } | ||
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the
probecommand did not consider namespaces when listing policies. This oversight caused policies to be appended across all namespaces with matching labels, leading to wrong display of information.To address this, I updated the
getPoliciesOnAnnotatedPodsfunction. It now returns both the list of policies and their corresponding namespaces. This allows us to ensure that policies are appended only when pods are in the same namespace and have the same labels.and also formatted the code using gofumpt 😊
Fixes
Testing
go run . probe