Permit literal string validation for CEL expressions #1754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to simplify usage of CEL in schema generation with
x_kube
macro, users interested in simple validation should be able to specify simple&str
data without additional syntax, like mandatory.into()
call for conversion intoRule
type required now.Solution
This change allows to write simple CEL expressions like so:
#[x_kube(validation = "self.nonNullable == oldSelf.nonNullable")]
as opposed to previous:
#[x_kube(validation = "self.nonNullable == oldSelf.nonNullable".into())]
or
#[x_kube(validation = Rule::new("self.metadata.name != 'forbidden'"))]
and combine multiple more complex expressions with different input types, in case a
message
or areason
context needs to be specified: