-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flowLabel, includeLabelInRouter flow fields + relabel output #1294
Added flowLabel, includeLabelInRouter flow fields + relabel output #1294
Conversation
5a98817
to
6bc017a
Compare
585d409
to
e2f0907
Compare
Signed-off-by: Peter Gvizd <[email protected]>
Signed-off-by: Peter Gvizd <[email protected]>
…gging#1291) Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Peter Gvizd <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Peter Gvizd <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Peter Gvizd <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Peter Gvizd <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Peter Gvizd <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Peter Gvizd <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Peter Gvizd <[email protected]>
Co-authored-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Peter Gvizd <[email protected]>
Signed-off-by: Peter Gvizd <[email protected]>
62edf18
to
1d74ed8
Compare
…-from-router-field
Signed-off-by: Peter Gvizd <[email protected]>
@pepov This is probably logic, that you requested 82747df , Or do you want to completely remove includeLabelInRouter param from user control, and drive it only by existence of FlowLabel? |
Signed-off-by: Peter Gvizd <[email protected]>
d6adc62
to
82747df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With some minor fixes, this is exactly what I was asking for, thank you!
Signed-off-by: Peter Gvizd <[email protected]>
Thank you as well, hope it is OK now |
…-from-router-field
@gvizdpeter thanks for the nice contribution, merging this now! |
Created a follow up issue for the docs: kube-logging/kube-logging.github.io#131 @gvizdpeter could you please help with the documentation part? No need to figure out the right place or the proper wording, just creating a sketch with a general description and the most important use-cases. |
Hello @pepov I will try to add something to opened issues. |
Does someone happen to have a nice example of this with the |
If concat produces messages with new labels, then you don't need relabel, just a flow with the label you want to redirect timeouted messages:
Maybe the question is what do you want to do with those messages ran into timeout? |
Fixes #1115