-
Notifications
You must be signed in to change notification settings - Fork 344
New Configuration Pages #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nomisRev
wants to merge
2
commits into
main
Choose a base branch
from
configuration-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
codeSnippets/snippets/embedded-server/src/main/kotlin/com/example/CIO.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package com.example | ||
|
||
import io.ktor.server.cio.CIO | ||
import io.ktor.server.engine.embeddedServer | ||
|
||
fun runConfiguredCIOProperties() { | ||
embeddedServer(CIO, configure = { | ||
connectionIdleTimeoutSeconds = 45 | ||
reuseAddress = false | ||
}) { | ||
module() | ||
}.start(true) | ||
} |
19 changes: 19 additions & 0 deletions
19
codeSnippets/snippets/embedded-server/src/main/kotlin/com/example/Jetty.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package com.example | ||
|
||
import io.ktor.server.engine.embeddedServer | ||
import io.ktor.server.jetty.jakarta.Jetty | ||
import org.eclipse.jetty.server.handler.ErrorHandler | ||
import kotlin.time.Duration.Companion.seconds | ||
|
||
fun runConfiguredJettyProperties() { | ||
embeddedServer(Jetty, configure = { | ||
configureServer = { | ||
errorHandler = MyErrorHandler() | ||
} | ||
idleTimeout = 30.seconds | ||
}) { | ||
module() | ||
}.start(true) | ||
} | ||
|
||
class MyErrorHandler : ErrorHandler() |
17 changes: 17 additions & 0 deletions
17
codeSnippets/snippets/embedded-server/src/main/kotlin/com/example/Tomcat.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package com.example | ||
|
||
import io.ktor.server.engine.embeddedServer | ||
import io.ktor.server.tomcat.jakarta.Tomcat | ||
|
||
fun runConfiguredTomcatProperties() { | ||
embeddedServer(Tomcat, configure = { | ||
configureTomcat = { | ||
with(connector) { | ||
enableLookups = false | ||
setProperty("maxThreads", "150") | ||
} | ||
} | ||
}) { | ||
module() | ||
}.start(true) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's confusing that the TOC title is "Server Configuration" but the topic one "Application Configuration". If I understand correctly, they are separate concepts, so we should either call this "Configuration" or "Server and application configuration". Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably oversight. I thought
Server and application configuration
was too long for the menu 😅I think
Server configuration
,Application configuration
, orServer and Application Configuration
all work.Server configuration
implies both "ktor server" and "my custom server logic", similarly forApplication
it refers to my ownApplication
and the KtorApplication
class.I personally have no strong opinion. It could also be moved "Ktor Configuration" to "Engines" but then we'd have to change the name and I think that might be move confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright then, I think it makes sense to keep the Ktor configurations here as opposed to the Engines topic.
Maybe @meilalina can help with the title :)