Skip to content

TypeDefinition fix for dotnet build#20

Open
mmintoff wants to merge 1 commit into
kswoll:masterfrom
mmintoff:type_definition_fix
Open

TypeDefinition fix for dotnet build#20
mmintoff wants to merge 1 commit into
kswoll:masterfrom
mmintoff:type_definition_fix

Conversation

@mmintoff
Copy link
Copy Markdown

@mmintoff mmintoff commented Jul 4, 2022

Build from Visual Studio works fine. dotnet build from something like Azure build pipeline does not and gives an exception "System.Type was somehow not found. Aborting." These modification address that problem and the artifacts are built correctly. Can be tested using powershell "dotnet build".

Build from Visual Studio works fine. dotnet build from something like Azure build pipeline does not and gives an exception "System.Type was somehow not found.  Aborting." These modification address that problem and the artifacts are built correctly. Can be tested using powershell "dotnet build".
@hughesjs
Copy link
Copy Markdown

Have you got a version of this with your changes in it published anywhere? I'm having some difficulty getting it to build and install right with a local package repo

@mmintoff
Copy link
Copy Markdown
Author

Have you got a version of this with your changes in it published anywhere? I'm having some difficulty getting it to build and install right with a local package repo

Nah, hoping @kswoll takes a look at this soonish. In the meantime you could clone and pack it locally

@hughesjs
Copy link
Copy Markdown

Yeah, I did try that but after running dotnet pack on the Fody.Someta project, installing it and then referencing the Someta one (since it didn't look like it produced a nupkg when built), it still wouldn't build.

Might try again later on a fresh clone though, could just be due to a messy set of partial build files with me having used various different versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants