Fix some bugs in the regression tests and add more regression tests #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cmd/ksh93/tests/{basic.sh,builtins.sh,shtests}:
- Redirect error output from the ulimit builtin to silence irrelevant
errors in the regression tests (these errors may occur when a
command such as 'ulimit -t 4' is run before the regression tests).
- Shellquote the error messages from the getconf regression tests.
src/cmd/ksh93/tests/{arrays,io,variables}.sh:
- Backport the ksh2020 regression tests for the following bugs:
<att#23>
<att#203>
<att#472>
<att#492>
src/cmd/ksh93/tests/{basic,pty}.sh:
- Add regression tests for the following bugs:
<att#1160>
<att#1461>
- The ksh2020 fix for [ -t 1 ] in non-forking command substitutions
caused the following bug in interactive shells:
$ ( [ -t 1 ]; echo $? )
1 # Always fails
To avoid introducing this bug, this commit adds a regression
test for it.
McDutchie
reviewed
May 3, 2021
- Move the test to the start of functions.sh (if it's at the end
of the script, it refuses to fail under ksh2020). Output from
this regression test when run against ksh2020:
$ bin/shtests -p functions
#### Regression-testing /home/johno/GitRepos/KornShell/ksh/arch/linux.i386-64/bin/ksh ####
test functions begins at 2021-05-02+21:22:19
functions.sh[46]: eval'ing function dumps function body to stdout (got $' { eval "bar() { FAILURE; }"; }\n { FAILURE; }')
- Use arithmetic for loop instead of seq.
In ksh93v- [[ -o ?posix ]] doesn't return an error (because it's implemented in the bash mode). However, 'set -o posix' will fail in ksh93v- if it's not in bash compatibility mode, which causes this test script to exit prematurely.
JohnoKing
force-pushed
the
extra-regress-tests
branch
from
e6dd0dd to
36d515a
Compare
|
LGTM now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/cmd/ksh93/tests/{basic.sh,builtins.sh,shtests}:
ulimitbuiltin to silence irrelevant errors in the regression tests (these errors may occur when a command such asulimit -t 4is run before the regression tests).getconfregression tests.src/cmd/ksh93/tests/{arrays,io,variables}.sh:
Regression appending to an indexed array overwrites arr[-1] if arr[0] is unset att/ast#23
Reading file through command substitution fails att/ast#203
Ksh's .sh.file contains garbage after returning from "sourcing" another file. att/ast#472
Something is wrong with
pathdevand thuspathcanon()att/ast#492src/cmd/ksh93/tests/{basic,pty}.sh:
ksh dumps function body to stdout and freezes when eval'ing a function definition att/ast#1160
Tab completion error when expanding ${.sh} att/ast#1461
[ -t 1 ]in non-forking command substitutions caused[ -t 1 ]to break in non-comsub virtual subshells (when used in interactive shells). Reproducer (which this pull request adds to the regression tests):